Add support for ScaledJob #435
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…21/k8s-deploy into bugfix/canary_promote_action
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds comprehensive support for KEDA ScaledJob resources to the k8s-deploy GitHub Action, addressing feature request #277. ScaledJob resources are now treated as first-class workload entities with proper handling of their nested structure for image pull secrets, labels, and deployment strategies.
Key Changes
Added ScaledJob to core type system in
KubernetesWorkload,WORKLOAD_TYPES, andDEPLOYMENT_TYPESmanifestPullSecretUtils.ts andmanifestSpecLabelUtils.tsto handle ScaledJob's nestedjobTemplatestructure (similar to CronJob)getReplicaCountto return 0 for ScaledJob since replicas are managed by KEDA