Ensure error messages display the correct namespace #458
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bosesuneha
reviewed
Oct 8, 2025
Member
bosesuneha
left a comment
bosesuneha
left a comment
There was a problem hiding this comment.
changes look good, just the commits need to be signed @duncan3dc
…de it on the deployment resource
…ck to the default if unavailable
auto-merge was automatically disabled
October 8, 2025 18:13
Head branch was pushed to by a user without write access
duncan3dc
force-pushed
the
error-namespace-fix
branch
from
f4fef7f to
0b442f5
Compare
Contributor
Author
|
Thanks everyone, I've rebased and signed them now |
bosesuneha
approved these changes
Oct 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you provide the namespace as an input to the action, and your manifests don't include the namespace, then when an error is displayed it states
namespace undefined:This PR provides a
getNamespace()helper method on theKubectlclass to expose its internal fallback logic to ensure the correct namespace is displayed