Skip to content

Add ImagePullPolicy and set it to PullAlways when deploying runners #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xinWeiWei24 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add ImagePullPolicy and set it to PullAlways when deploying runners #211

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions runner/group/handler.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -378,8 +378,9 @@ func (h *Handler) buildBatchJobObject(uploadURL string) *batchv1.Job {
Affinity: &corev1.Affinity{},
Containers: []corev1.Container{
{
Name: "runner",
Image: h.imageRef,
Name: "runner",
Image: h.imageRef,
ImagePullPolicy: corev1.PullAlways,
Copy link
Contributor

@wonderyl wonderyl Sep 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm concerning this will make running runners slower. When you release a new node, do you give it a new tag or reuse the tag? I'm asking because technically if you give it a new tag in every build, you won't have the problem of stale images.

Env: []corev1.EnvVar{
{
Name: "POD_NAME",
Expand Down
Loading