Skip to content

Add encrypted caching support for PoP token flow#676

Merged
weinong merged 29 commits intoAzure:mainfrom
vineeth-thumma:main
Oct 8, 2025
Merged

Add encrypted caching support for PoP token flow#676
weinong merged 29 commits intoAzure:mainfrom
vineeth-thumma:main

Conversation

@vineeth-thumma
Copy link
Copy Markdown
Contributor

@vineeth-thumma vineeth-thumma commented Jul 8, 2025

Relevant WI - https://msazure.visualstudio.com/AzureArcPlatform/_workitems/edit/35025798

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jul 10, 2025

Codecov Report

❌ Patch coverage is 37.26170% with 362 lines in your changes missing coverage. Please review.
✅ Project coverage is 52.26%. Comparing base (15edb67) to head (c9acd8c).
⚠️ Report is 54 commits behind head on main.

Files with missing lines Patch % Lines
pkg/internal/pop/cache/linux.go 0.00% 126 Missing ⚠️
pkg/internal/pop/msal_public.go 34.90% 61 Missing and 8 partials ⚠️
pkg/internal/pop/cache/internal/jwe/jwe.go 52.63% 24 Missing and 12 partials ⚠️
pkg/internal/pop/cache/cache.go 0.00% 29 Missing ⚠️
pkg/internal/pop/cache/internal/aescbc/aescbc.go 68.65% 14 Missing and 7 partials ⚠️
pkg/internal/pop/poptoken.go 66.66% 11 Missing and 5 partials ⚠️
...ernal/token/interactivebrowsercredentialwithpop.go 42.85% 10 Missing and 2 partials ⚠️
...nternal/token/usernamepasswordcredentialwithpop.go 33.33% 10 Missing and 2 partials ⚠️
pkg/internal/testutils/govcrutils.go 0.00% 11 Missing ⚠️
pkg/internal/pop/msal_confidential.go 60.00% 6 Missing and 2 partials ⚠️
... and 4 more
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #676       +/-   ##
===========================================
- Coverage   63.43%   52.26%   -11.18%     
===========================================
  Files          37       47       +10     
  Lines        2210     2960      +750     
===========================================
+ Hits         1402     1547      +145     
- Misses        733     1270      +537     
- Partials       75      143       +68     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@vineeth-thumma vineeth-thumma marked this pull request as ready for review July 17, 2025 17:18
@vineeth-thumma
Copy link
Copy Markdown
Contributor Author

@weinong Can you please review this?

@weinong weinong requested a review from Copilot August 14, 2025 00:32

This comment was marked as outdated.

@vineeth-thumma vineeth-thumma changed the title PoP token cache flow using MSAL cache Add caching for PoP token flow Sep 18, 2025
@vineeth-thumma vineeth-thumma changed the title Add caching for PoP token flow Add encrypted caching support for PoP token flow Sep 18, 2025
@weinong weinong requested a review from Copilot September 22, 2025 19:06
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 30 out of 38 changed files in this pull request and generated 2 comments.

Comments suppressed due to low confidence (1)

pkg/internal/pop/msal_confidential.go:63

  • Unsafe type assertion without checking if Transport is actually an *http.Client. This could panic if Transport is a different type that implements http.RoundTripper.
		confOptions = append(confOptions,
			confidential.WithHTTPClient(msalOptions.Options.Transport.(*http.Client)),
		)

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 30 out of 38 changed files in this pull request and generated 6 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@weinong weinong requested a review from Copilot October 6, 2025 17:45
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 32 out of 41 changed files in this pull request and generated 1 comment.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@vineeth-thumma vineeth-thumma requested a review from weinong October 8, 2025 01:24
Copy link
Copy Markdown
Contributor

@weinong weinong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@weinong weinong merged commit bd07cfe into Azure:main Oct 8, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants