phase2 changes for app components and server metricss config. #109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radhikajain99
previously approved these changes
Feb 21, 2025
mohitpavan
changed the base branch from
users/mohit/phase1-changes-cicd
to
main
mohitpavan
dismissed
radhikajain99’s stale review
The base branch was changed.
…rs/mohit/phase2-app-comps-server-comps
mohitpavan
temporarily deployed
to
automation test
GitHub Actions
Inactive
mohitpavan
had a problem deploying
to
automation test
GitHub Actions
Failure
mohitpavan
had a problem deploying
to
automation test
GitHub Actions
Failure
mohitpavan
had a problem deploying
to
automation test
GitHub Actions
Error
mohitpavan
had a problem deploying
to
automation test
GitHub Actions
Error
mohitpavan
had a problem deploying
to
automation test
GitHub Actions
Error
mohitpavan
had a problem deploying
to
automation test
GitHub Actions
Error
mitsha-microsoft
approved these changes
Feb 21, 2025
|
|
||
| async createTestAPI() { | ||
| let urlSuffix = "tests/"+this.testId+"?api-version="+ ApiVersionConstants.tm2024Version; | ||
| let urlSuffix = "tests/"+this.testId+"?api-version="+ ApiVersionConstants.latestVersion; |
Member
There was a problem hiding this comment.
For a later PR, we can refactor the API version fetching into a function getApiVersion(). That way whenever we want to change the API version, we dont need to change all methods here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title: [Phase2: CICD Improvements] adding app comps and server comps.
Adding app components and server configuration support in the config yaml file.
Tested pretty good number of scenarios in the local.
No risk.