Skip to content

Conversation

@jmclong
Copy link
Contributor

@jmclong jmclong commented Jun 12, 2025

This pull request introduces several updates to improve multi-architecture support, enhance Docker image handling, and update example configurations. The changes include adding ARM64 support, refining Docker build processes, and modifying example StatefulSet configurations.

Multi-Architecture Support:

  • Added ARM64 to the supported architectures in the daemonset.yaml file for Kubernetes DaemonSet scheduling. (charts/latest/templates/daemonset.yaml)
  • Introduced a new ARM-specific AKS integration test configuration in the E2E workflow. (.github/workflows/test-e2e.yml)
  • Added a new deployment parameters file for ARM-based NVMe configuration. (deploy/parameters/nvme-arm.json)

Docker Build Improvements:

  • Fixed a bug with the Dockerfile that created arm64 image on the build target (needed to have that omitted)
  • Refactored Docker tag handling in the E2E workflow to dynamically generate tags, improving maintainability. (.github/workflows/test-e2e.yml)
  • Updated the Dockerfile to remove the platform constraint from the FROM statements, simplifying the build process. (Dockerfile) [1] [2]
  • Adjusted the Makefile to align the ARCH variable with the Docker --platform format and fixed the platform argument in the Docker build command. (Makefile) [1] [2]

Example Configuration Updates:

  • Updated the example StatefulSet to use busybox instead of nginx, increased replicas to 5, and replaced persistent storage with ephemeral storage. (examples/nvme/statefulset.yaml) [1] [2]
  • Example did not support ARM

@jmclong
Copy link
Contributor Author

jmclong commented Jun 13, 2025

Waiting for removal of cert-manager. The MCR build doesn't have arm64 support

@jmclong jmclong merged commit a56b9d1 into Azure:main Jun 16, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants