-
Notifications
You must be signed in to change notification settings - Fork 8
fix(dockerfile): arm64 test and dockerfile and target is not build platform #30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5f0c2f2 to
39a83f9
Compare
croomes
approved these changes
Jun 12, 2025
Contributor
Author
|
Waiting for removal of cert-manager. The MCR build doesn't have arm64 support |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several updates to improve multi-architecture support, enhance Docker image handling, and update example configurations. The changes include adding ARM64 support, refining Docker build processes, and modifying example StatefulSet configurations.
Multi-Architecture Support:
daemonset.yamlfile for Kubernetes DaemonSet scheduling. (charts/latest/templates/daemonset.yaml).github/workflows/test-e2e.yml)deploy/parameters/nvme-arm.json)Docker Build Improvements:
.github/workflows/test-e2e.yml)Dockerfileto remove the platform constraint from theFROMstatements, simplifying the build process. (Dockerfile) [1] [2]Makefileto align theARCHvariable with the Docker--platformformat and fixed the platform argument in the Docker build command. (Makefile) [1] [2]Example Configuration Updates:
busyboxinstead ofnginx, increased replicas to 5, and replaced persistent storage with ephemeral storage. (examples/nvme/statefulset.yaml) [1] [2]