Skip to content

Updated parameters for global ini parameters and added unit tests #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Oct 23, 2025
Merged

Updated parameters for global ini parameters and added unit tests #138

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
a5b18a2
Add unit tests for ConfigurationCheckModule
devanshjainms Oct 21, 2025
cf52097
Enhance HAClusterValidator to support multiple DR provider configurat…
devanshjainms Oct 21, 2025
1c4e82b
Fix parameter logging in HAClusterValidator and update global INI con…
devanshjainms Oct 21, 2025
28174e8
Refactor conditionals in configuration checks and update Azure Load B…
devanshjainms Oct 22, 2025
a96cd4e
Enhance configuration checks to support IBM DB2 alongside SAP HANA, u…
devanshjainms Oct 22, 2025
025b38e
Standardize DB2 naming across configuration files to ensure consisten…
devanshjainms Oct 22, 2025
c6c46e1
Standardize naming for DB2 to Db2 across configuration files for cons…
devanshjainms Oct 22, 2025
de7b627
Enhance Azure Load Balancer module to handle various IP address forma…
devanshjainms Oct 22, 2025
53e2e11
Refactor user parameter handling in CommandCollector and update DB2 u…
devanshjainms Oct 22, 2025
2e871f8
Add min_list validation for kernel parameters and update related tests
devanshjainms Oct 22, 2025
5aaa577
Improve validation logic in ConfigurationCheckModule to handle intege…
devanshjainms Oct 22, 2025
6ab09fa
Update DB2 user handling and command execution in db2.yml; include db…
devanshjainms Oct 22, 2025
468f84f
Enhance min_list validation in ConfigurationCheckModule to handle exc…
devanshjainms Oct 22, 2025
9ba6b87
Update documentation and improve configuration check reporting; enhan…
devanshjainms Oct 22, 2025
495116e
Refactor test cases in get_azure_lb_test.py to streamline frontend_ip…
devanshjainms Oct 23, 2025
9c1e470
Refactor AzureLoadBalancer to simplify private IP address retrieval; …
devanshjainms Oct 23, 2025
e1f159a
Add Azure login instructions to CONFIGURATION_CHECKS.md; update secti…
devanshjainms Oct 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
77 changes: 38 additions & 39 deletions src/modules/get_pcmk_properties_db.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,45 +273,44 @@ def _parse_global_ini_parameters(self):
) as file:
global_ini_content = file.read().splitlines()

section_start = (
global_ini_content.index("[ha_dr_provider_sushanasr]")
if self.saphanasr_provider == HanaSRProvider.ANGI
else global_ini_content.index("[ha_dr_provider_SAPHanaSR]")
)
properties_slice = global_ini_content[section_start + 1 : section_start + 4]

global_ini_properties = {
key.strip(): val.strip()
for line in properties_slice
for key, sep, val in [line.partition("=")]
if sep
}

for param_name, expected_config in global_ini_defaults.items():
value = global_ini_properties.get(param_name, "")
if isinstance(expected_config, dict):
expected_value = expected_config.get("value")
is_required = expected_config.get("required", False)
else:
expected_value = expected_config
is_required = False

self.log(
logging.INFO,
f"param_name: {param_name}, value: {value}, expected_value: {expected_config}",
)
parameters.append(
self._create_parameter(
category="global_ini",
name=param_name,
value=value,
expected_value=(
expected_config.get("value")
if isinstance(expected_config, dict)
else expected_value
),
)
)
for section_name, section_properties in global_ini_defaults.items():
try:
section_start = global_ini_content.index(f"[{section_name}]")
next_section_start = len(global_ini_content)
for i in range(section_start + 1, len(global_ini_content)):
if global_ini_content[i].strip().startswith("["):
next_section_start = i
break

properties_slice = global_ini_content[section_start + 1 : next_section_start]

global_ini_properties = {
key.strip(): val.strip()
for line in properties_slice
for key, sep, val in [line.partition("=")]
if sep and key.strip()
}

for param_name, expected_config in section_properties.items():
value = global_ini_properties.get(param_name, "")
expected_value = expected_config.get("value", "")

self.log(
logging.INFO,
f"param_name: {param_name}, value: {value}, "
+ f"Fexpected_value: {expected_value}",
)
parameters.append(
self._create_parameter(
category="global_ini",
subcategory=section_name,
name=param_name,
value=value,
expected_value=expected_value,
)
)
except ValueError:
self.log(logging.WARNING, f"Section {section_name} not found in global.ini")
except Exception as ex:
self.log(logging.ERROR, f"Error parsing global.ini: {str(ex)}")

Expand Down
107 changes: 80 additions & 27 deletions src/roles/ha_db_hana/tasks/files/constants.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -801,36 +801,89 @@ OS_PARAMETERS:
GLOBAL_INI:
SUSE:
SAPHanaSR:
provider:
value: "SAPHanaSR"
required: true
path:
value: ["/usr/share/SAPHanaSR", "/hana/shared/myHooks"]
required: true
execution_order:
value: "1"
required: true
ha_dr_provider_SAPHanaSR:
provider:
value: "SAPHanaSR"
required: true
path:
value: ["/usr/share/SAPHanaSR", "/hana/shared/myHooks"]
required: true
execution_order:
value: "1"
required: true
ha_dr_provider_suschksrv:
provider:
value: "susChkSrv"
required: true
path:
value: ["/usr/share/SAPHanaSR", "/hana/shared/myHooks"]
required: true
execution_order:
value: "3"
required: true
action_on_host:
value: "fence"
required: true
trace:
ha_dr_sushanasr:
required: false
SAPHanaSR-angi:
provider:
value: "susHanaSR"
required: true
path:
value: ["/usr/share/SAPHanaSR-angi", "/hana/shared/myHooks"]
required: true
execution_order:
value: "1"
required: true
ha_dr_provider_sushanasr:
provider:
value: "susHanaSR"
required: true
path:
value: ["/usr/share/SAPHanaSR-angi", "/hana/shared/myHooks"]
required: true
execution_order:
value: "1"
required: true
ha_dr_provider_suschksrv:
provider:
value: "susChkSrv"
required: true
path:
value: ["/usr/share/SAPHanaSR-angi", "/hana/shared/myHooks"]
required: true
execution_order:
value: "3"
required: true
action_on_host:
value: "fence"
required: true
trace:
ha_dr_sushanasr:
required: false
ha_dr_suschksrv:
required: false
REDHAT:
SAPHanaSR:
provider:
value: "SAPHanaSR"
required: true
path:
value: ["/usr/share/SAPHanaSR/srHook", "/hana/shared/myHooks"]
required: true
execution_order:
value: "1"
required: true
ha_dr_provider_SAPHanaSR:
provider:
value: "SAPHanaSR"
required: true
path:
value: ["/usr/share/SAPHanaSR/srHook", "/hana/shared/myHooks"]
required: true
execution_order:
value: "1"
required: true
ha_dr_provider_suschksrv:
provider:
value: "susChkSrv"
required: true
path:
value: ["/usr/share/SAPHanaSR", "/hana/shared/myHooks"]
required: true
execution_order:
value: "3"
required: true
action_on_host:
value: "fence"
required: true
trace:
ha_dr_sushanasr:
required: false

# === Azure Load Balancer ===
# Azure Load Balancer configuration
Expand Down
Loading