Update timeout configurations for ANF and AFS in resource defaults #77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the timeout configurations in the RESOURCE_DEFAULTS to differentiate timeout settings for ANF and AFS resource operations.
- Updated the monitor operation timeout under RESOURCE_DEFAULTS to use separate mappings for ANF and AFS instead of a single timeout list.
- Applied the same change consistently to two segments within the constants.yaml file.
Comments suppressed due to low confidence (2)
src/roles/ha_scs/tasks/files/constants.yaml:109
- Changing the timeout configuration from a single timeout list to a resource-specific mapping requires confirming that all consumers of RESOURCE_DEFAULTS are updated to handle this new structure. Please verify that the relevant parts of the application correctly process the mapping format.
ANF: ["105", "105s"]
src/roles/ha_scs/tasks/files/constants.yaml:136
- Ensure that the adjusted timeout configuration mapping for monitor operations is supported by all consuming modules. This change from a universal list to resource-specific mappings may require corresponding updates in the code that reads these values.
ANF: ["105", "105s"]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the
RESOURCE_DEFAULTSconfiguration in theconstants.yamlfile to introduce resource-specific timeout values for operations. The changes primarily focus on differentiating timeout settings forANFandAFSresources.Updates to resource operation timeouts:
src/roles/ha_scs/tasks/files/constants.yaml: Modified thetimeoutfield underoperations.monitorto specify distinct timeout values forANF(["105", "105s"]) andAFS(["60", "60s"]) resources. Previously, a single timeout value was applied universally. [1] [2]