Fix: Resolve multiple bugs in setup WorkloadZone in ADO causing silent failures

[nnoaman]

Summary

Fixes multiple bugs in New-SDAFADOWorkloadZone that caused false success reporting and resources created in wrong projects.

Issues Addressed

• Variable groups created in wrong Azure DevOps project
• Service connection creation failing silently
• Wrong Managed Identity property causing authentication failures

Changes

1. Add Azure DevOps configuration

Files: New-SDAFADOWorkloadZone.ps1, SDAFUtilities.psm1

The function now calls az devops configure --defaults at the beginning to ensure all operations target the correct organization and project. This matches the pattern used in New-SDAFADOProject.

2. Fix Managed Identity Client ID query

Changed .id to .clientId in the az identity list query:

- az identity list --query "[?principalId=='...'].id"
+ az identity list --query "[?principalId=='...'].clientId"

The previous code returned the full ARM resource ID instead of the client ID required for service connection authentication.

3. Add error handling for service connection creation

Added $LASTEXITCODE checks after all az devops service-endpoint commands. The function now properly reports failures instead of displaying false success messages.

  az devops service-endpoint create --service-endpoint-configuration $JsonInputFile --organization $AdoOrganization --project $AdoProject --output none --only-show-errors
+ if ($LASTEXITCODE -ne 0) {
+     Write-Error "Failed to create service connection"
+     throw "Service connection creation failed"
+ }
  Write-Host "Service connection '$ConnectionName' created successfully." -ForegroundColor Green

[Copilot]

Pull request overview

This PR addresses critical bugs in the New-SDAFADOWorkloadZone function that caused silent failures when setting up Azure DevOps workload zones. The changes fix service connection authentication issues and add error handling to prevent false success reporting.

Changes:

• Added Azure DevOps configuration defaults to ensure operations target the correct organization and project
• Fixed Managed Identity property query to use clientId instead of id for service connection authentication
• Added error handling for service connection creation commands to detect and report failures

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.

File	Description
New-SDAFADOWorkloadZone.ps1	Added az devops configure defaults, fixed managed identity client ID query, and added error handling for service connection creation
New-SDAFADOProject.ps1	Added error handling for service connection creation to match the pattern in New-SDAFADOWorkloadZone
SDAFUtilities.psm1	Compiled module containing the same changes as the source files above

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.