-
Notifications
You must be signed in to change notification settings - Fork 435
Serialize and deserialize actor token in claims identity #3219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
saurabhsathe-ms
wants to merge
59
commits into
dev
Choose a base branch
from
ssathe/serializeClaimsIdentity
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+2,028
−22
Open
Changes from 13 commits
Commits
Show all changes
59 commits
Select commit
Hold shift + click to select a range
105e513
Added a test case to test presence of Signature in JsonWebToken. This…
saurabhsathe-ms b5c02e6
Included reference and implemented serialization logic
saurabhsathe-ms 90d5667
Added a json parser that can parse the stringified claim without brea…
saurabhsathe-ms 2a0c1b1
Found an ovverriden create token method for our requirement. Removing…
saurabhsathe-ms 9b0c1bd
Added a check to ensure that the claimvalue is a valid json
saurabhsathe-ms b7a2280
Added logic to handle actor token from claims dictionary. Updated tes…
saurabhsathe-ms 7b65a01
Updated JsonWebTokenHandlerCreateToken.cs to accomodate new changes. …
saurabhsathe-ms cd264f5
Removed the print statements and added header
saurabhsathe-ms a7b578d
"ActorTokenInClaimsDictionaryShouldBeProperlySerialized" now properly…
saurabhsathe-ms 7a657e9
Added new testcases, added comments to testcase and modified existing…
saurabhsathe-ms 04257cd
NIT repairs
saurabhsathe-ms d354200
Added one testcase to test MaxActorChainLength values.
saurabhsathe-ms ff64ddd
Removed Console.Writeline debugging statements
saurabhsathe-ms f66c4d0
Moved the Actor chain length parameter into a Configuration class tha…
saurabhsathe-ms 5dc4a49
Made the configuration class public and static
saurabhsathe-ms ccb0688
Update src/Microsoft.IdentityModel.JsonWebTokens/JsonWebTokenHandler.…
saurabhsathe-ms 92a6285
Update src/Microsoft.IdentityModel.JsonWebTokens/JsonWebTokenHandler.…
saurabhsathe-ms 99f7fd5
Repaired testcases as per the suggestions on PR
saurabhsathe-ms 4185264
Renamed JsonWebTokenConfiguration to JsonWebTokenHandlerConfiguration
saurabhsathe-ms 8dcbdb3
Removed the comments on testcase
saurabhsathe-ms 89cd0e4
Updated the configuration summary.
saurabhsathe-ms 3ad51eb
Moved the MaxActorChainLength to SecurityTokenDescriptor
saurabhsathe-ms 3f348bc
All test cases passed and introduced JWTclaimTypeName
saurabhsathe-ms 787099b
Updated JsonWebToken.cs to now use SecurityTokenDescriptor.ActorClaim…
saurabhsathe-ms a92b6d6
Introduced a flag that we will be using to turn the feature on or off
saurabhsathe-ms 36623ea
Cleaned the code and brought it all under one function
saurabhsathe-ms e3c25f9
Implemented non static version of ActorClaimName
saurabhsathe-ms e20d067
Removed console lines, Added a condition to check if the max actor ch…
saurabhsathe-ms d531454
moved actor chain depth to Security Token Descriptor
saurabhsathe-ms d79c61b
Updated validation parameters to validate JWT token upto a certain limit
saurabhsathe-ms f7de606
Removed old serialization. Added json object serialization and update…
saurabhsathe-ms f3c6ed2
Removed the changes to PublicUnshipped files for each frameworks
saurabhsathe-ms 4185c6f
Added a delegate that users can use to validate their token
saurabhsathe-ms 4c57aaf
NIT repairs round 1
saurabhsathe-ms a585112
Removed everything from TokenValidationParameters and the delegate
saurabhsathe-ms e6638ae
Revert "Removed everything from TokenValidationParameters and the del…
saurabhsathe-ms 95db310
Renamed the switch and removed the validation code
saurabhsathe-ms 9a1f6ed
Changed delegate name and added the tests to test our new function?
saurabhsathe-ms 5e10aec
Added a testcase to test if act claim was properly deserialized
saurabhsathe-ms 3b21635
Updated my local branch with dev
saurabhsathe-ms a7398a8
Created delegate and added testcases
saurabhsathe-ms a8efcb8
Fixed one bug in Deserialization. Divided all the testcases in 2 part…
saurabhsathe-ms 4d2770f
NIT repairs, renamed some fields and adjusted some default values as …
saurabhsathe-ms bd78d2e
Some more NIT repairs
saurabhsathe-ms 9503403
Merge branch 'dev' into ssathe/serializeClaimsIdentity
saurabhsathe-ms 78cc3bc
Updated the code custom actclaimretrievervalidator call with token va…
saurabhsathe-ms bbb2f02
Updated summary for our new AppContextSwitch
saurabhsathe-ms e7952d1
Removed App context switch replaced it with request based property
saurabhsathe-ms e3e47ee
NIT updates
saurabhsathe-ms 06b5820
Merge branch 'dev' into ssathe/serializeClaimsIdentity
saurabhsathe-ms 1dfda65
Removed the use of flag during serialization and everything is working
saurabhsathe-ms 6caaae5
Removed the flag from SecurityTokenDescriptor altogether
saurabhsathe-ms 7cbe282
Removed the flag from token validation parameters too. Also added one…
saurabhsathe-ms 8eede12
Latest pull
saurabhsathe-ms e5ce2bc
Merge branch 'ssathe/serializeClaimsIdentityWithoutFlag' into ssathe/…
saurabhsathe-ms e28773c
Resolved feedback!
saurabhsathe-ms badf08a
Change HasKey with TryGetValue for perf improvement
saurabhsathe-ms 2c23923
Merge branch 'dev' into ssathe/serializeClaimsIdentity
saurabhsathe-ms 2ab6ef6
Merge with main
saurabhsathe-ms File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
src/Microsoft.IdentityModel.JsonWebTokens/Microsoft.IdentityModel.JsonWebTokens.csproj
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| static Microsoft.IdentityModel.JsonWebTokens.JsonWebTokenHandler.MaxActorChainLength.get -> int | ||
| static Microsoft.IdentityModel.JsonWebTokens.JsonWebTokenHandler.MaxActorChainLength.set -> void |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.