Provide support to Log using ILogger #3265
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SummarySummary
CoverageMicrosoft.IdentityModel.JsonWebTokens - 80.3%
|
src/Microsoft.IdentityModel.Tokens/Extrensions/TokenValidationParametersExtensions.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.IdentityModel.Tokens/Extrensions/TokenValidationParametersExtensions.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.IdentityModel.Tokens/Extrensions/TokenValidationParametersExtensions.cs
Outdated
Show resolved
Hide resolved
pmaytak
reviewed
Jun 17, 2025
pmaytak
reviewed
Jun 17, 2025
src/Microsoft.IdentityModel.Logging/Microsoft.IdentityModel.Logging.csproj
Show resolved
Hide resolved
pmaytak
reviewed
Jun 18, 2025
src/Microsoft.IdentityModel.JsonWebTokens/JsonWebTokenHandler.ValidateToken.cs
Outdated
Show resolved
Hide resolved
brentschmaltz
force-pushed
the
brentsch/SupportILogger
branch
2 times, most recently
from
62411d8 to
7476fcb
Compare
brentschmaltz
force-pushed
the
brentsch/SupportILogger
branch
from
7476fcb to
98d6f3a
Compare
SummarySummary
CoverageMicrosoft.IdentityModel.JsonWebTokens - 80.3%
|
| ActivityId = activityId; | ||
| } | ||
|
|
||
| #pragma warning disable CS3001 // ILogger is not CLSCompliant |
Contributor
There was a problem hiding this comment.
It would be better to mark these with
[CLSCompliant(false)]
| public LoggerContext(ILogger logger, string correlationId) | ||
| { | ||
| Logger = logger ?? throw new ArgumentNullException(nameof(logger)); | ||
| CorrelationId = correlationId; |
Contributor
There was a problem hiding this comment.
We could check if the correlation id is a guid, if it is, then set the activity id with it
pmaytak
approved these changes
Aug 8, 2025
| } | ||
| } | ||
|
|
||
| Assert.True(logCount == theoryData.LogValues.Count, |
Contributor
There was a problem hiding this comment.
nit: Use Assert.Equal for these.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This work creates an entry point for use of ILogger for capturing logs.
It sets a pattern that will be expanded to include additional logs, but first we want to establish an acceptable model.
This PR focuses on Validation of Lifetime, Issuer and Audience and will be expanded with other PR's.