[SIWG] Pass Sign In With Google credential to broker, Fixes AB#3100603 #2573
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❌ Work item link check failed. Description does not contain AB#{ID}. Click here to Learn more. |
|
✅ Work item link check complete. Description contains link AB#3100603 to an Azure Boards work item. |
|
❌ Work item link check failed. Description contains AB#3100603 but the Bot could not link it to an Azure Boards work item. Click here to learn more. |
github-actions
bot
changed the title
mohitc1
changed the title
mohitc1
changed the title
somalaya
reviewed
Jan 27, 2025
| /** | ||
| * The newest Msal-To-Broker protocol version. | ||
| * | ||
| * @see <a href="https://identitydivision.visualstudio.com/DevEx/_git/AuthLibrariesApiReview?path=/%5BAndroid%5D%20Broker%20API/broker_protocol_versions.md">Android Auth Broker Protocol Versions</a> |
Contributor
There was a problem hiding this comment.
Once you merge the PR, could you also update the version in the link above?
...on/src/main/java/com/microsoft/identity/common/internal/msafederation/FederatedCredential.kt
Outdated
Show resolved
Hide resolved
somalaya
approved these changes
Jan 27, 2025
shahzaibj
reviewed
Jan 28, 2025
...va/com/microsoft/identity/common/internal/msafederation/google/SignInWithGoogleCredential.kt
Outdated
Show resolved
Hide resolved
shahzaibj
reviewed
Jan 28, 2025
...on/src/main/java/com/microsoft/identity/common/internal/msafederation/FederatedCredential.kt
Outdated
Show resolved
Hide resolved
mohitc1
added
the
Skip-Consumers-Check
shahzaibj
reviewed
Jan 29, 2025
...rc/main/java/com/microsoft/identity/common/internal/msafederation/MsaFederationExtensions.kt
Outdated
Show resolved
Hide resolved
shahzaibj
approved these changes
Jan 29, 2025
mohitc1
added a commit
to AzureAD/microsoft-authentication-library-for-android
that referenced
this pull request
Jan 29, 2025
Small in change in response to changes in Android Common Refer below PRs. common: AzureAD/microsoft-authentication-library-common-for-android#2573 Broker: AzureAD/ad-accounts-for-android#3038
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes AB#3100603
The PR adds to allow passing google id token credential from app side (in OneAuth) to Android Broker via Android Common.
OneAuth can get the id token by using Sign In With Google component added earlier and pass it to Android Broker via BrokerRequest object.
Changes include:
Related PRs:
Broker: https://github.com/AzureAD/ad-accounts-for-android/pull/3038
MSAL: AzureAD/microsoft-authentication-library-for-android#2247