Removing unnecessary attributes from keystore wrap operation, Fixes AB#3137956 #2578
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❌ Work item link check failed. Description does not contain AB#{ID}. Click here to Learn more. |
melissaahn
approved these changes
Jan 29, 2025
iamgusain
approved these changes
Jan 29, 2025
somalaya
changed the title
somalaya
changed the title
|
✅ Work item link check complete. Description contains link AB#3137956 to an Azure Boards work item. |
somalaya
force-pushed
the
somalaya/KeystoreUnwrapFix
branch
from
2ccf081 to
5b80300
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In an older PR, I replaced the deprecated Keystore API for Android 28+
But it did not fix the issue of unwrap keystore operation failing on some Pixel 5 devices. Since it is not reproducing on other devices, I am removing the unnecessary attributes from the keystore wrap operation to see if it fixes the issue. certificate parameters are no longer actively used in other parts of the code. Hence removed those.
I have already shared the test build with 2 customers and the issue has NOT reproduced on their devices so far with this fix.
Fixes AB#3137956