Pedroro/release/20.0.0 #2589
Merged
Pedroro/release/20.0.0 #2589
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue : Some specific device models do not like the purpose "PURPOSE_WRAP_KEY" to be passed while doing a keypair generation. Root cause : Changes made in this PR https://github.com/AzureAD/microsoft-authentication-library-common-for-android/pull/2558/files IcM : https://portal.microsofticm.com/imp/v5/incidents/details/592800555/summary Fix : 1. Added fallback mechanism to skip using wrap_key purpose when the SecureKeyImportUnavailableException occurs. 2. If the fallback mentioned in step 1 fails, we fallback to legacy keygen spec method. 3. Added telemetry to capture which method was finally successful and also the time taken to generate the keypair 4. Also kept my changes behind a flight to turn it off in case of any failures Manually tested below steps 1. Signed in with an AAD account with the flight for using the latest KeyGenParameterSpec as ON in MsalTestApp with BrokerHost as the broker 5. Tried ATS ---> Succeeds 6. Tried getBrokerAccounts API from BrokerHost app ---> Succeeds 7. Did a device registration -- Succeeds ----------------------------------------------------------------------------- 8. Assuming some issue happened, I turned off the flight 9. Tried ATS ---> Succeeds 10. Tried ATI with same UPN --> Succeeds 11. Tried getBrokerAccounts API from BrokerHost app ---> Succeeds 12. Tried to get WPJ entries --> Gets them correctly Fixes [AB#3146656](https://identitydivision.visualstudio.com/fac9d424-53d2-45c0-91b5-ef6ba7a6bf26/_workitems/edit/3146656)
|
❌ Work item link check failed. Description does not contain AB#{ID}. Click here to Learn more. |
iamgusain
approved these changes
Feb 10, 2025
somalaya
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.