-
Notifications
You must be signed in to change notification settings - Fork 46
Gradle version change from AGP 7.4.2 to 8.1.1, Fixes AB#2779502 #2652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…AB#27795…" This reverts commit 654872f.
|
❌ Work item link check failed. Description does not contain AB#{ID}. Click here to Learn more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR upgrades the build infrastructure to Gradle 8.1.1 and AGP 8.1.1, adjusts Android module configurations, replaces deprecated Gradle APIs, and switches CI pipelines to JDK 1.17.
- Bump Gradle wrapper and plugin versions (gradleVersion, AGP, msal4j, buildsystem plugin)
- Add
namespaceand enablebuildConfig/aidlin Android modules; replaceclassifierwitharchiveClassifier.set - Update Azure Pipelines templates and jobs to use Java 1.17
Reviewed Changes
Copilot reviewed 20 out of 20 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| uiautomationutilities/src/main/AndroidManifest.xml | Remove hardcoded package, relying on Gradle namespace |
| uiautomationutilities/build.gradle | Added namespace, buildConfig feature, switched to archiveClassifier |
| testutils/src/main/AndroidManifest.xml | Removed package attribute |
| testutils/build.gradle | Added namespace, buildConfig feature, switched to archiveClassifier |
| gradle/wrapper/gradle-wrapper.properties | Updated distributionUrl to Gradle 8.1-all.zip |
| gradle/versions.gradle | Bumped gradleVersion to 8.1.1 and msal4jVersion to 1.20.1 |
| gradle.properties | Replaced MaxPermSize with MaxMetaspaceSize in JVM args comment |
| common4j/gradle/wrapper/gradle-wrapper.properties | Updated distributionUrl to Gradle 8.1-all.zip |
| common4j/build.gradle | Bumped buildsystem plugin, added generateBuildConfig dep, updated jars |
| common/build.gradle | Bumped plugin, enabled buildConfig/aidl, switched to archiveClassifier, refined CI task deps and POM logic |
| common-java-root/gradle/wrapper/gradle-wrapper.properties | Updated distributionUrl to Gradle 8.1-all.zip |
| common-java-root/gradle.properties | Replaced MaxPermSize with MaxMetaspaceSize in JVM args comment |
| changelog.txt | Added entry for AGP upgrade to 8.1.1 |
| azure-pipelines/templates/steps/spotbugs.yml | Introduced javaVersion parameter to drive jdkVersionOption |
| azure-pipelines/templates/steps/continuous-delivery/assemble-publish-projversion.yml | Switched jdkVersionOption to 1.17 |
| azure-pipelines/pull-request-validation/lab-utilities.yml | Added JDK 1.17 selections |
| azure-pipelines/pull-request-validation/common4j.yml | Added JDK 1.17 selections |
| azure-pipelines/pull-request-validation/common.yml | Switched CI jobs to Java 1.17 |
| azure-pipelines/pull-request-validation/build-consumers.yml | Switched CI jobs to Java 1.17 |
| LabApiUtilities/build.gradle | Bumped buildsystem plugin to 0.2.5 |
|
✅ Work item link check complete. Description contains link AB#2779502 to an Azure Boards work item. |
Reverts #2651
Same as this PR created by Jeffrey -- #2587
I previously merged the above PR and realized that it was some extra changes were needed in related broker PR and there was not enough time to make the changes, So I reverted it.
Successful builds :
common4j Build and Test : https://identitydivision.visualstudio.com/Engineering/_build/results?buildId=1493462&view=results
common Build and Test : https://identitydivision.visualstudio.com/Engineering/_build/results?buildId=1493463&view=results
Fixes AB#2779502