Skip to content

Native auth: Update Email OTP MFA to Match EC Implementation, Fixes AB#3351233 #2760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nilo-ms merged 6 commits into from
Sep 18, 2025

make sure MFA OOB is used when code for MFA is submitted

26deb12
Select commit
Loading
Failed to load commit list.
Merged

Native auth: Update Email OTP MFA to Match EC Implementation, Fixes AB#3351233 #2760

make sure MFA OOB is used when code for MFA is submitted
26deb12
Select commit
Loading
Failed to load commit list.
Azure Pipelines / Common4j - Build & Test failed Sep 12, 2025 in 8m 32s

Build #20250912.2 had test failures

1 errors / 5 warnings

Details

Tests

  • Failed: 1 (0.15%)
  • Passed: 685 (99.56%)
  • Other: 2 (0.29%)
  • Total: 688

Annotations

Check failure on line 90 in Build log

See this annotation in the file changed.

@azure-pipelines azure-pipelines / Common4j - Build & Test

Build log #L90 

Error: The process 'D:\a\1\s\gradlew.bat' failed with exit code 1

Check failure on line 1 in testSignInTokenWithEmptyOOBShouldThrowException

See this annotation in the file changed.

@azure-pipelines azure-pipelines / Common4j - Build & Test

testSignInTokenWithEmptyOOBShouldThrowException 

java.lang.Exception: Unexpected exception, expected<com.microsoft.identity.common.java.exception.ClientException> but was<java.lang.NullPointerException>
Raw output 
java.lang.Exception: Unexpected exception, expected<com.microsoft.identity.common.java.exception.ClientException> but was<java.lang.NullPointerException>
	at org.junit.internal.runners.statements.ExpectException.evaluate(ExpectException.java:30)
	at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
	at org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)
	at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63)
	at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
	at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)
	at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
	at org.junit.runners.ParentRunner.run(ParentRunner.java:413)
	at org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecutor.runTestClass(JUnitTestClassExecutor.java:112)
	at org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecutor.execute(JUnitTestClassExecutor.java:58)
	at org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecutor.execute(JUnitTestClassExecutor.java:40)
	at org.gradle.api.internal.tasks.testing.junit.AbstractJUnitTestClassProcessor.processTestClass(AbstractJUnitTestClassProcessor.java:54)
	at org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.processTestClass(SuiteTestClassProcessor.java:53)
	at jdk.internal.reflect.GeneratedMethodAccessor32.invoke(Unknown Source)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:569)
	at org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:36)
	at org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
	at org.gradle.internal.dispatch.ContextClassLoaderDispatch.dispatch(ContextClassLoaderDispatch.java:33)
	at org.gradle.internal.dispatch.ProxyDispatchAdapter$DispatchingInvocationHandler.invoke(ProxyDispatchAdapter.java:92)
	at jdk.proxy1/jdk.proxy1.$Proxy4.processTestClass(Unknown Source)
	at org.gradle.api.internal.tasks.testing.worker.TestWorker$2.run(TestWorker.java:183)
	at org.gradle.api.internal.tasks.testing.worker.TestWorker.executeAndMaintainThreadName(TestWorker.java:132)
	at org.gradle.api.internal.tasks.testing.worker.TestWorker.execute(TestWorker.java:103)
	at org.gradle.api.internal.tasks.testing.worker.TestWorker.execute(TestWorker.java:63)
	at org.gradle.process.internal.worker.child.ActionExecutionWorker.execute(ActionExecutionWorker.java:56)
	at org.gradle.process.internal.worker.child.SystemApplicationClassLoaderWorker.call(SystemApplicationClassLoaderWorker.java:121)
	at org.gradle.process.internal.worker.child.SystemApplicationClassLoaderWorker.call(SystemApplicationClassLoaderWorker.java:71)
	at worker.org.gradle.process.internal.worker.GradleWorkerMain.run(GradleWorkerMain.java:69)
	at worker.org.gradle.process.internal.worker.GradleWorkerMain.main(GradleWorkerMain.java:74)
Caused by: java.lang.NullPointerException: isMFAGrantType is marked non-null but is null
	at com.microsoft.identity.common.java.nativeauth.commands.parameters.SignInSubmitCodeCommandParameters.<init>(SignInSubmitCodeCommandParameters.java:38)
	at com.microsoft.identity.common.java.nativeauth.commands.parameters.SignInSubmitCodeCommandParameters$SignInSubmitCodeCommandParametersBuilderImpl.build(SignInSubmitCodeCommandParameters.java:38)
	at com.microsoft.identity.common.java.nativeauth.providers.NativeAuthRequestProviderTest.testSignInTokenWithEmptyOOBShouldThrowException(NativeAuthRequestProviderTest.kt:850)
	at java.base/jdk.internal.reflect.
View more details on Azure Pipelines