Reset flights between tests, Fixes AB#3413737 #2794
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❌ Work item link check failed. Description does not contain AB#{ID}. Click here to Learn more. |
somalaya
added
the
No-Changelog
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a test isolation issue where flight settings were persisting between test cases, causing testUrlOverrideHandlesNonceRedirectUrl to fail. The fix ensures proper test cleanup by resetting the flights manager after test execution.
- Added flight manager reset call to prevent state leakage between tests
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...com/microsoft/identity/common/internal/ui/webview/AzureActiveDirectoryWebViewClientTest.java
Outdated
Show resolved
Hide resolved
somalaya
changed the title
|
✅ Work item link check complete. Description contains link AB#3413737 to an Azure Boards work item. |
|
❌ Work item link check failed. Description contains AB#3413737 Click here to learn more. |
rpdome
approved these changes
Oct 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The testcase testUrlOverrideHandlesNonceRedirectUrl was failing because there was a new testcase introduced in the class where we were setting flights but we missed resetting them before the next testcase runs.
Fix : Resetting flights between the UTs
Additional fix : There was a change that was relying on the state of flights set in previous tests which was incorrect. Correcting this as well.
Fixes AB#3413737