Sjain/add new span for async operation Fixes AB#3170313 #2798
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new telemetry span PersistToStorageAsync for tracking asynchronous storage operations in the broker, and fixes an account matching bug in the token cache by ensuring environment checks are consistently applied when matching accounts with their credentials.
- Added new span name
PersistToStorageAsyncto the SpanName enum for telemetry tracking - Fixed account-credential matching logic to include environment comparison at the credential level
- Updated documentation to reflect the corrected behavior
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| SpanName.java | Added PersistToStorageAsync enum value for telemetry tracking of async storage operations |
| MsalOAuth2TokenCache.java | Fixed bug where environment wasn't being checked when matching accounts to credentials, ensuring proper account ownership validation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
✅ Work item link check complete. Description contains link AB#3170313 to an Azure Boards work item. |
|
❌ Work item link check failed. Description contains AB#3170313 but the Bot could not link it to an Azure Boards work item. Click here to learn more. |
siddhijain
added
the
No-Changelog
andwhysoft
approved these changes
Oct 28, 2025
shahzaibj
approved these changes
Oct 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new span to be used in broker. Fixes AB#3170313