Edge TB: Updating execute method definition, Fixes AB#3423519 #2807
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
melissaahn
added
the
No-Changelog
|
❌ Work item link check failed. Description does not contain AB#{ID}. Click here to Learn more. |
1 similar comment
|
❌ Work item link check failed. Description does not contain AB#{ID}. Click here to Learn more. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for additional required parameters in WebApps operations by introducing a new data class WebAppsAdditionalRequiredParameters and updating the broker controller's API. It also adds a new error constant FLIGHT_DISABLED for feature flight scenarios.
Key changes:
- Adds
FLIGHT_DISABLEDerror string constant for handling disabled feature flights - Introduces
WebAppsAdditionalRequiredParametersdata class to encapsulate metadata about calling applications (package name, app name/version, SDK type/version) and UI capability flag - Updates
executeWebAppRequestmethod signature to accept the new additional parameters
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| common4j/src/main/com/microsoft/identity/common/java/exception/ErrorStrings.java | Adds FLIGHT_DISABLED error constant for feature flight validation scenarios |
| common/src/main/java/com/microsoft/identity/common/internal/controllers/BrokerMsalController.java | Updates executeWebAppRequest method signature to include WebAppsAdditionalRequiredParameters parameter and imports the new data class |
| common/src/main/java/com/microsoft/identity/common/internal/broker/ipc/WebAppsAQdditionalRequiredParameters.kt | Introduces new data class containing caller metadata and UI capability flag for WebApps broker operations (note: filename contains critical spelling error) |
...ava/com/microsoft/identity/common/internal/broker/ipc/WebAppsAdditionalRequiredParameters.kt
Show resolved
Hide resolved
...ava/com/microsoft/identity/common/internal/broker/ipc/WebAppsAdditionalRequiredParameters.kt
Show resolved
Hide resolved
github-actions
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updating the execute method definition so that OneAuth can start mocking request if they'd like.
AB#3423519