Add support for OneBox Environment, Fixes AB#3113751 #2231
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❌ Work item link check failed. Description does not contain AB#{ID}. Click here to Learn more. |
shahzaibj
changed the title
shahzaibj
changed the title
shahzaibj
changed the title
melissaahn
approved these changes
Dec 27, 2024
Contributor
melissaahn
left a comment
melissaahn
left a comment
There was a problem hiding this comment.
Are real devices able to make use of this support as well? Or just emulators?
Contributor
Author
Real physical devices can use this too. That's what I've been using. Just need to make sure that it is connected to same network where local eSTS is running. So you may need a proxy or VPN to send traffic from mobile device to PC where eSTS is running. |
shahzaibj
changed the title
|
✅ Work item link check complete. Description contains link AB#3113751 to an Azure Boards work item. |
github-actions
bot
changed the title
shahzaibj
added a commit
to AzureAD/microsoft-authentication-library-common-for-android
that referenced
this pull request
Jan 8, 2025
Fixes [AB#3113751](https://identitydivision.visualstudio.com/fac9d424-53d2-45c0-91b5-ef6ba7a6bf26/_workitems/edit/3113751) Changes to allow MSAL/Broker to talk to eSTS running locally. This basically does the following: - Add build config flag to bypass authority validation. This is required because local eSTS authorities are not discovered via cloud discovery. We can enable this flag locally in gradle project properties to target local eSTS. - Read the port number of the authority when constructing the cloud URL because targeting local eSTS requires supplying exact port. I've scoped the change to read port only when environment is specified as onebox. Related MSAL PR: AzureAD/microsoft-authentication-library-for-android#2231
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes AB#3113751
Adds a new MSAL config file for the OneBox environment. This specifies exact authority that onebox is using.
Related common PR: AzureAD/microsoft-authentication-library-common-for-android#2559