Native Auth E2E test fix, Fixes AB#3125466 #2244
Conversation
|
❌ Work item link check failed. Description does not contain AB#{ID}. Click here to Learn more. |
github-actions
bot
changed the title
Yuki-YuXin
changed the title
Yuki-YuXin
changed the title
| * Use valid email address, but invalid OTP to receive "invalid code" error. | ||
| * (use case 2.2.7) | ||
| */ | ||
| @Ignore("1secmail service is down. Ignoring test for now.") |
There was a problem hiding this comment.
For this test we don't retrieve an OTP code from the email inbox, so it should not be ignored
There was a problem hiding this comment.
This account has been locked.
There was a problem hiding this comment.
There was a problem hiding this comment.
Can you use the correct explanation why we're skipping this test? We're skipping it because the user is blocked not for 1secmail service. Please, update all the other tests that apply
| * Sign up with email + OTP. Server requires password authentication, which is not supported by the developer (aka redirect flow). | ||
| * (use case 2.1.10) | ||
| */ | ||
| @Ignore("1secmail service is down. Ignoring test for now.") |
There was a problem hiding this comment.
For this test we don't retrieve an OTP code from the email inbox, so it should not be ignored
There was a problem hiding this comment.
Hi @nilo-ms , for the following 3 test cases, please refer to this build https://identitydivision.visualstudio.com/Engineering/_build/results?buildId=1413056&view=logs&j=6f26e4aa-3eaf-5d24-2c84-463275687676&t=733235bb-4511-5023-8af6-9a666fd33e21
Although the test case itself has no relation with the OTP code.
com.microsoft.identity.internal.test.labapi.ApiException:
at com.microsoft.identity.internal.test.labapi.ApiClient.handleResponse(ApiClient.java:911)
at com.microsoft.identity.internal.test.labapi.ApiClient.execute(ApiClient.java:827)
at com.microsoft.identity.internal.testutils.nativeauth.api.TemporaryEmailService$TemporaryEmailApi.generateRandomEmailAddress(TemporaryEmailService.kt:142)
It used genRandomMailbox from the service.
There was a problem hiding this comment.
Thanks Yuki, on iOS we generate the random email address locally with the following code:
func generateRandomEmailAddress() -> String {
let randomId = UUID().uuidString.prefix(8)
return "native-auth-signup-\(randomId)@1secmail.org"
}
Can you please do the same on Android? So, we don't need to use 1secmail for this or similar test
There was a problem hiding this comment.
Good suggestions. Done.
There would be a company PR in common #2244
There was a problem hiding this comment.
I need to merge the common PR first then update the submodule then run the pipeline here.
There was a problem hiding this comment.
Thanks Yuki, I think the right link to the common PR is this one:
AzureAD/microsoft-authentication-library-common-for-android#2570
I approved that PR
| private val defaultChallengeTypes = listOf("password", "oob") | ||
|
|
||
|
|
||
| @Ignore("1secmail service is down. Ignoring test for now.") |
There was a problem hiding this comment.
For this test we don't retrieve an OTP code from the email inbox, so it should not be ignored
| * Sign up with email + password. Developer makes a request with password that does not match password complexity requirements set on portal. | ||
| * (use case 1.1.13) | ||
| */ | ||
| @Ignore("1secmail service is down. Ignoring test for now.") |
There was a problem hiding this comment.
For this test we don't retrieve an OTP code from the email inbox, so it should not be ignored
...c/test/java/com/microsoft/identity/client/e2e/tests/network/nativeauth/SignInEmailOTPTest.kt
Outdated
Show resolved
Hide resolved
| * Sign up with email + OTP. Resend email OTP. | ||
| * (hero scenario 1, use case 2.1.5) | ||
| */ | ||
| @Ignore("1secmail service is down. Ignoring test for now.") |
There was a problem hiding this comment.
Do we still need to ignore this test after you made the change around random email generation?
| * Sign up with email + OTP. Verify email address using email OTP and sign up. | ||
| * (hero scenario 1, use case 2.1.1) | ||
| */ | ||
| @Ignore("1secmail service is down. Ignoring test for now.") |
Make changes inside TemporaryEmailService.kt to generate random email account locally. Please refer to the MSAL PR: AzureAD/microsoft-authentication-library-for-android#2244
The third party of 1secmail used for E2E test OTP code fetching is down.
Common PR: AzureAD/microsoft-authentication-library-common-for-android#2570
Fixes AB#3125466