Skip to content

Conversation

@somalaya
Copy link
Contributor

Version Updates:

Updated JDK to version 1.17.
Upgraded Gradle to version 8.1.1.
Changed Gradle distribution URL to 8.1-all.
Dependency Updates:

Updated build system plugin to version 0.2.5.
Build Configuration Changes:

Added namespace properties in build.gradle files as per the new Gradle feature.
Updated Gradle task configurations to use new properties.
Adjusted Maven publishing configurations for different build types.
Removed deprecated properties and replaced them with updated ones.
Android Manifest Changes:

Commented out package declarations to align with the namespace property requirements in Gradle.
Pipeline and CI/CD Updates:

Updated Gradle tasks to use Java 17 home directory.
Adjusted JDK version in pipeline tasks from 1.11 to 1.17.
Working Pipeline runs using my branch of common:
MSAL -Build and Test: https://identitydivision.visualstudio.com/Engineering/_build/results?buildId=1466968&view=results

Common PR: AzureAD/microsoft-authentication-library-common-for-android#2587
MSAL PR: #2254
Broker PR: https://github.com/AzureAD/ad-accounts-for-android/pull/3052
Azuresample PR: Azure-Samples/ms-identity-android-java#85
AB#2779502

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR upgrades the Android Gradle Plugin from 7.4.2 to 8.1.1 and updates several related build components including JDK, Gradle versions, and build configurations. Key changes include updating Gradle and JDK versions, applying new namespace properties in AndroidManifest and build.gradle files, and updating documentation in the changelog.

Reviewed Changes

Copilot reviewed 16 out of 16 changed files in this pull request and generated no comments.

Show a summary per file
File Description
testapps/testapp/src/main/AndroidManifest.xml Removed package attribute as per namespace requirements.
testapps/testapp/build.gradle Added namespace and enabled buildConfig in buildFeatures.
pop-benchmarker/src/main/AndroidManifest.xml Removed package attribute in line with new Gradle practices.
pop-benchmarker/build.gradle Added namespace property to align with Android manifest changes.
package-inspector/src/main/AndroidManifest.xml Removed package attribute to follow new guidelines.
package-inspector/build.gradle Added namespace property for consistency.
msalautomationapp/src/androidTest/AndroidManifest.xml Removed package declaration per updated requirements.
msalautomationapp/build.gradle Added namespace and buildFeatures update.
msal/src/main/AndroidManifest.xml Removed package declaration to align with project guidelines.
msal/build.gradle Upgraded buildsystem plugin, added namespace, updated javadoc and PMD tasks.
gradle/wrapper/gradle-wrapper.properties Upgraded Gradle distribution URL to 8.1-all.
gradle/versions.gradle Updated gradleVersion to 8.1.1.
gradle.properties Updated JVM arguments to reflect new Java metaspace settings.
common Updated submodule commit.
changelog Updated changelog entry reflecting AGP version update.
azure-pipelines/pull-request-validation/pr-msal.yml Updated JDK version from 1.11 to 1.17 in pipeline configurations.
Comments suppressed due to low confidence (1)

changelog:5

  • The changelog entry references AGP Version 8.1.0, while the PR title and description indicate 8.1.1. Please update the changelog for consistency.
- [MINOR] Update AGP Version to 8.1.0 (#2254)

@somalaya somalaya closed this Jun 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants