ignore 3 federated tests #2357
Merged
ignore 3 federated tests #2357
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR temporarily disables three federated authentication tests that are currently failing due to infrastructure issues. The tests use a lab API that doesn't have VMs allocated for federated auth, causing false positive failures.
- Added
@Ignoreannotations to three test classes with appropriate explanatory messages - Updated the
commonsubmodule reference
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| TestCase938368.java | Added @ignore annotation to disable MSAL-only US Gov federated test |
| TestCase833553.java | Added @ignore annotation to disable broker non-joined federated test |
| TestCase1561147.java | Added @ignore annotation to disable broker joined federated test |
| common | Updated submodule reference |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
...com/microsoft/identity/client/msal/automationapp/testpass/msalonly/usgov/TestCase938368.java
Show resolved
Hide resolved
...m/microsoft/identity/client/msal/automationapp/testpass/broker/nonjoined/TestCase833553.java
Show resolved
Hide resolved
...com/microsoft/identity/client/msal/automationapp/testpass/broker/joined/TestCase1561147.java
Show resolved
Hide resolved
melissaahn
approved these changes
Aug 19, 2025
somalaya
approved these changes
Aug 20, 2025
shahzaibj
approved these changes
Aug 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ignore 3 federated tests
These tests use a lab api which currently does not have VMs allocated for federated auth. Ignoring these tests as they are currently failing as false flags.