Skip to content

Conversation

@melissaahn
Copy link
Contributor

@melissaahn melissaahn commented Aug 22, 2025

Summary

AB#3330213

We got a report from a partner team that they were seeing very low amounts (like 5 instances) of an NPE related to AccountAdapter. Looking at past related issues, this seems like some account entry data got malformed for particular accounts/devices, perhaps due to very old broker versions. The patch in this PR is to add null checks for both the home and local id from the guest account, and if either are null, then it won't be added to the guest account array.

@github-actions
Copy link

❌ Work item link check failed. Description does not contain AB#{ID}.

Click here to Learn more.

@github-actions github-actions bot added the msal label Aug 22, 2025
@github-actions github-actions bot changed the title Add null checks for guest account ids Add null checks for guest account ids, Fixes AB#3330213 Aug 22, 2025
@melissaahn melissaahn marked this pull request as ready for review August 22, 2025 01:02
Copilot AI review requested due to automatic review settings August 22, 2025 01:02
@melissaahn melissaahn requested review from a team as code owners August 22, 2025 01:02
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds null safety checks to prevent NPE (NullPointerException) when processing guest account IDs in the AccountAdapter, addressing a production issue where malformed account data caused crashes.

  • Added null checks for both home and local account IDs before performing string operations
  • Updated changelog to document the patch

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
AccountAdapter.java Added null validation for home and local account IDs to prevent NPE when filtering guest accounts
changelog Documented the patch for guest account ID null checks

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@melissaahn melissaahn merged commit 5524027 into dev Aug 26, 2025
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants