Fix for App Link Usage in DUNA / SSO scenarios #2363
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❌ Work item link check failed. Description does not contain AB#{ID}. Click here to Learn more. |
shahzaibj
changed the title
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses App Link usage in DUNA (Device-based Unified Authentication) and SSO scenarios by migrating from deprecated LocalBroadcastManager to standard Android broadcast mechanisms and updating dependencies.
- Replaces LocalBroadcastManager with standard Android broadcast receivers for improved compatibility
- Updates browser library dependency from version 1.0.0 to 1.7.0
- Adds proper receiver registration handling for Android 13+ security requirements
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| CurrentTaskBrowserTabActivity.java | Migrates from LocalBroadcastManager to standard broadcasts with proper Android 13+ security handling |
| gradle/versions.gradle | Updates browser library dependency to version 1.7.0 |
| common | Updates submodule commit reference |
| changelog | Documents the fix in release notes |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
msal/src/main/java/com/microsoft/identity/client/CurrentTaskBrowserTabActivity.java
Show resolved
Hide resolved
msal/src/main/java/com/microsoft/identity/client/CurrentTaskBrowserTabActivity.java
Outdated
Show resolved
Hide resolved
p3dr0rv
approved these changes
Aug 28, 2025
melissaahn
approved these changes
Aug 28, 2025
msal/src/main/java/com/microsoft/identity/client/CurrentTaskBrowserTabActivity.java
Outdated
Show resolved
Hide resolved
melissaahn
approved these changes
Aug 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See related common PR: AzureAD/microsoft-authentication-library-common-for-android#2745