-
Notifications
You must be signed in to change notification settings - Fork 138
Add stress test for ATS to msaltestapp, Fixes AB#3404910 #2391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
❌ Work item link check failed. Description does not contain AB#{ID}. Click here to Learn more. |
|
❌ Work item link check failed. Description contains AB#3404910 <img but the Bot could not link it to an Azure Boards work item. Click here to learn more. |
|
✅ Work item link check complete. Description contains link AB#3404910 to an Azure Boards work item. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds concurrent stress testing functionality for AcquireTokenSilent operations to the MSAL Android test application. The feature allows testing how MSAL handles multiple simultaneous token acquisition requests.
Key Changes:
- Added UI controls for configuring concurrent execution parameters (thread count and total requests)
- Implemented a new ConcurrentAcquireTokenExecutor class to handle multi-threaded token acquisition with progress tracking
- Modified RequestOptions class visibility to support the new concurrent testing feature
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| fragment_acquire.xml | Added UI section with input fields and buttons for concurrent ATS testing |
| RequestOptions.java | Made class public and added getter method for configuration access |
| ConcurrentAcquireTokenExecutor.kt | New Kotlin class implementing concurrent token acquisition with progress callbacks |
| AcquireTokenFragment.java | Added concurrent execution logic and UI event handlers |
| common | Updated submodule reference |
testapps/testapp/src/main/java/com/microsoft/identity/client/testapp/RequestOptions.java
Show resolved
Hide resolved
...estapp/src/main/java/com/microsoft/identity/client/testapp/ConcurrentAcquireTokenExecutor.kt
Outdated
Show resolved
Hide resolved
...estapp/src/main/java/com/microsoft/identity/client/testapp/ConcurrentAcquireTokenExecutor.kt
Outdated
Show resolved
Hide resolved
6ef0a79 to
e5b5fce
Compare
…estapp/ConcurrentAcquireTokenExecutor.kt Co-authored-by: Copilot <[email protected]>
…estapp/ConcurrentAcquireTokenExecutor.kt Co-authored-by: Copilot <[email protected]>
AB#3404910
NOTE: in order for this to work, the build config
shouldSkipSilentTokenCommandCacheForStressTestmust be set to true.Otherwise, the redundant requests will be absorbed by the CommandDispatcher cache and it won't be fired concurrently to broker.
See AzureAD/microsoft-authentication-library-common-for-android#2786)