Skip to content

Conversation

@rpdome
Copy link
Member

@rpdome rpdome commented Oct 15, 2025

AB#3404910

NOTE: in order for this to work, the build config shouldSkipSilentTokenCommandCacheForStressTest must be set to true.
Otherwise, the redundant requests will be absorbed by the CommandDispatcher cache and it won't be fired concurrently to broker.

See AzureAD/microsoft-authentication-library-common-for-android#2786)

image

@github-actions
Copy link

❌ Work item link check failed. Description does not contain AB#{ID}.

Click here to Learn more.

@rpdome rpdome changed the title Add stress test to msaltestapp Add stress test for ATS to msaltestapp Oct 15, 2025
@github-actions
Copy link

❌ Work item link check failed. Description contains AB#3404910

<img but the Bot could not link it to an Azure Boards work item.

Click here to learn more.

@github-actions
Copy link

✅ Work item link check complete. Description contains link AB#3404910 to an Azure Boards work item.

@rpdome rpdome added the No-Changelog This change does not update the changelog. label Oct 15, 2025
@rpdome rpdome marked this pull request as ready for review October 15, 2025 22:40
@rpdome rpdome requested review from a team as code owners October 15, 2025 22:40
Copilot AI review requested due to automatic review settings October 15, 2025 22:40
@github-actions github-actions bot changed the title Add stress test for ATS to msaltestapp Add stress test for ATS to msaltestapp, Fixes AB#3404910 Oct 15, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds concurrent stress testing functionality for AcquireTokenSilent operations to the MSAL Android test application. The feature allows testing how MSAL handles multiple simultaneous token acquisition requests.

Key Changes:

  • Added UI controls for configuring concurrent execution parameters (thread count and total requests)
  • Implemented a new ConcurrentAcquireTokenExecutor class to handle multi-threaded token acquisition with progress tracking
  • Modified RequestOptions class visibility to support the new concurrent testing feature

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
fragment_acquire.xml Added UI section with input fields and buttons for concurrent ATS testing
RequestOptions.java Made class public and added getter method for configuration access
ConcurrentAcquireTokenExecutor.kt New Kotlin class implementing concurrent token acquisition with progress callbacks
AcquireTokenFragment.java Added concurrent execution logic and UI event handlers
common Updated submodule reference

@rpdome rpdome force-pushed the rapong/benchmarker branch from 6ef0a79 to e5b5fce Compare October 15, 2025 22:42
rpdome and others added 2 commits October 15, 2025 15:50
…estapp/ConcurrentAcquireTokenExecutor.kt

Co-authored-by: Copilot <[email protected]>
…estapp/ConcurrentAcquireTokenExecutor.kt

Co-authored-by: Copilot <[email protected]>
@rpdome rpdome merged commit 9b2bbab into dev Oct 24, 2025
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

No-Changelog This change does not update the changelog. testapps

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants