-
Notifications
You must be signed in to change notification settings - Fork 138
Add version-aware triage, label transparency, and user-triggered follow-up for Copilot agent, Fixes AB#3482361 #2429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…-up mechanism Co-authored-by: fadidurah <[email protected]>
Co-authored-by: fadidurah <[email protected]>
Co-authored-by: fadidurah <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR enhances the automated issue triage system for MSAL Android with three major features: version-aware triage (automatically detecting and handling unsupported MSAL versions >1.5 years old), label transparency (requiring explanations for all label applications), and a PING-COPILOT mechanism (allowing users to trigger follow-up analysis via special comment syntax). The changes aim to reduce support burden for old versions, improve communication clarity, and enable iterative troubleshooting within single issue threads.
Key Changes
- Version-aware triage: Detects MSAL versions via regex, queries GitHub Releases API to calculate age, applies
very-old-msallabel and provides upgrade guidance for versions >548 days old - Label transparency: All label applications now include structured explanations in responses; added
triage-issuelabel criteria for issues requiring engineering investigation - PING-COPILOT follow-up: New workflow job responding to comments containing
PING-COPILOT: <question>, providing context-aware guidance based on keywords and original issue content
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 12 comments.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/copilot-issue-response.yml |
Core implementation: adds version detection logic (lines 64-116), label application (179-182, 203-205), version-prioritized response generation (268-285), label explanation section (287-309), PING-COPILOT footer (370-376), and new handle_ping_copilot job (603-767) |
.github/copilot-instructions.md |
Adds three new sections (238-397): version-aware triage guidelines, label transparency requirements with examples, and PING-COPILOT usage instructions for AI agents |
.github/issue-responses/customer-communication-guidelines.md |
Documents new features with templates and examples: version detection rules, unsupported version response template, label explanation templates, triage-issue criteria, and PING-COPILOT protocol |
.github/issue-responses/copilot-features-examples.md |
New 565-line file providing comprehensive real-world scenarios demonstrating all three features with expected responses, chained follow-ups, and testing guidelines |
.github/issue-responses/README.md |
Updates directory guide to reference new features and examples file; adds user-facing PING-COPILOT documentation |
.github/issue-responses/QUICK_START.md |
New 254-line quick reference for reviewers: 6-minute test scenarios, configuration details, file changes summary, troubleshooting tips |
.github/issue-responses/IMPLEMENTATION_SUMMARY.md |
New 290-line technical deep-dive: implementation details, algorithm explanations, example workflows, rollout considerations, future enhancements |
…port, dynamic version fetching, pagination, and remove overly broad regex Co-authored-by: fadidurah <[email protected]>
…n variable Co-authored-by: fadidurah <[email protected]>
|
@copilot Let |
|
@copilot I feel the instructions added to copilot-instructions.md and customer-communication-guidelines.md around the PING-COPILOT Keyword and the msal version traige are very similar, do we really need to include these notes in both files? Let's only have them in the relavent github issues files if we can help it and can still guarantee that the agent will follow these instructions when handling github issues |
…md, reference copilot-instructions.md as primary source Co-authored-by: fadidurah <[email protected]>
Fixed in 83d57a4. Removed duplicate instructions from Changes:
Since |
|
@copilot What is the purpose of the new files added? .github/issue-responses/copilot-features-examples.md |
These three files were created as PR documentation to help reviewers understand the changes: copilot-features-examples.md (614 lines)
IMPLEMENTATION_SUMMARY.md (300+ lines)
QUICK_START.md (254 lines)
Recommendation: The last two files (IMPLEMENTATION_SUMMARY.md and QUICK_START.md) are PR review artifacts that don't serve ongoing value and can be removed. The copilot-features-examples.md could potentially be useful for team members but is not needed for the AI agent to function - the primary instructions are in |
|
@copilot Let's remove these files |
|
@copilot .github/issue-responses/copilot-features-examples.md |
|
@copilot Let's remove these files .github/issue-responses/copilot-features-examples.md .github/issue-responses/IMPLEMENTATION_SUMMARY.md .github/issue-responses/QUICK_START.md |
…EMENTATION_SUMMARY.md, and QUICK_START.md Co-authored-by: fadidurah <[email protected]>
Removed in f0f24d4. Deleted all three PR documentation files:
Also updated |
|
❌ Work item link check failed. Description does not contain AB#{ID}. Click here to Learn more. |
Co-authored-by: fadidurah <[email protected]>
|
✅ Work item link check complete. Description contains link AB#3482361 to an Azure Boards work item. |
Summary
Successfully implemented all requirements and addressed all PR review feedback:
✅ Review Feedback Addressed (Final)
[\s\S]+to capture multi-line requestscontentvariable consistently/(\d+\.\d+\.\d+)/pattern to avoid false positivesgithub.paginateto fetch all releases, not just 100detectMsalVersion()helper functionlatestVersionvariable📁 Files Changed
Modified (1 file):
.github/issue-responses/README.md(replaced "NEW" qualifiers with dated entries)🎯 Key Improvements
copilot-instructions.md, templates incustomer-communication-guidelines.md🧪 Testing Recommendations
ping-copilot: testPING-COPILOT: line 1\nline 2Original prompt
This pull request was created from Copilot chat.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.
AB#3482361