Skip to content

Fix for #5375 - Add a FormatResultAsync to IAuthenticationOperation #5376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix for #5375 - Add a FormatResultAsync to IAuthenticationOperation #5376

wants to merge 3 commits into from

Conversation

bgavrilMS
Copy link
Member

@bgavrilMS bgavrilMS commented Jul 9, 2025 •
edited
Loading

Fixes #5375

Create an IAuthenticationOperation2 interface with the new method.

@bgavrilMS bgavrilMS requested a review from a team as a code owner July 9, 2025 18:37
@bgavrilMS bgavrilMS requested a review from jmprieur July 9, 2025 18:43
@bgavrilMS bgavrilMS force-pushed the bogavril/formatResult branch from e6d762a to 8587584 Compare July 9, 2025 20:18
@bgavrilMS bgavrilMS requested a review from trwalke July 10, 2025 20:47
@bgavrilMS bgavrilMS force-pushed the bogavril/formatResult branch from 98e72cf to 884b3c6 Compare July 14, 2025 11:51
neha-bhargava
neha-bhargava reviewed Jul 29, 2025
View reviewed changes
src/client/Microsoft.Identity.Client/Extensibility/MsalAuthenticationExtension.cs
@@ -20,7 +20,7 @@ public class MsalAuthenticationExtension
public Func<OnBeforeTokenRequestData, Task> OnBeforeTokenRequestHandler { get; set; }

/// <summary>
/// Enables the developer to provide a custom authentication extension.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep this comment along with the added comment maybe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmprieur jmprieur jmprieur left review comments

@trwalke trwalke trwalke left review comments

@neha-bhargava neha-bhargava neha-bhargava approved these changes

@gladjohn gladjohn gladjohn approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request] Make FormatResult async
5 participants
@bgavrilMS @jmprieur @trwalke @neha-bhargava @gladjohn