-
Notifications
You must be signed in to change notification settings - Fork 373
Enable mTLS Proof‑of‑Possession for Client‑Assertion Delegates #5409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgavrilMS
reviewed
Jul 29, 2025
...ent/Microsoft.Identity.Client/Internal/ClientCredential/ClientAssertionDelegateCredential.cs
Outdated
Show resolved
Hide resolved
bgavrilMS
requested changes
Jul 29, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't use GetAwaiter / GetResult
bgavrilMS
reviewed
Jul 29, 2025
src/client/Microsoft.Identity.Client/ApiConfig/AcquireTokenForClientParameterBuilder.cs
Outdated
Show resolved
Hide resolved
bgavrilMS
reviewed
Jul 29, 2025
...ent/Microsoft.Identity.Client/Internal/ClientCredential/ClientAssertionDelegateCredential.cs
Outdated
Show resolved
Hide resolved
bgavrilMS
reviewed
Jul 29, 2025
bgavrilMS
reviewed
Jul 29, 2025
tests/Microsoft.Identity.Test.Unit/PublicApiTests/ClientAssertionTests.cs
Outdated
Show resolved
Hide resolved
bgavrilMS
reviewed
Jul 29, 2025
src/client/Microsoft.Identity.Client/AppConfig/ConfidentialClientApplicationBuilder.cs
Outdated
Show resolved
Hide resolved
bgavrilMS
reviewed
Jul 29, 2025
tests/Microsoft.Identity.Test.Unit/PublicApiTests/ClientAssertionTests.cs
Show resolved
Hide resolved
trwalke
reviewed
Aug 1, 2025
...ent/Microsoft.Identity.Client/Internal/ClientCredential/ClientAssertionDelegateCredential.cs
Outdated
Show resolved
Hide resolved
trwalke
reviewed
Aug 1, 2025
tests/Microsoft.Identity.Test.Unit/PublicApiTests/ClientAssertionTests.cs
Show resolved
Hide resolved
trwalke
reviewed
Aug 1, 2025
tests/Microsoft.Identity.Test.Unit/PublicApiTests/ConfidentialClientApplicationTests.cs
Outdated
Show resolved
Hide resolved
a71bc45
to
b84be19
Compare
bgavrilMS
reviewed
Aug 11, 2025
src/client/Microsoft.Identity.Client/ApiConfig/AcquireTokenForClientParameterBuilder.cs
Outdated
Show resolved
Hide resolved
f6f5a31
to
cac7a77
Compare
bgavrilMS
reviewed
Aug 13, 2025
src/client/Microsoft.Identity.Client/ApiConfig/AcquireTokenForClientParameterBuilder.cs
Outdated
Show resolved
Hide resolved
bgavrilMS
reviewed
Aug 13, 2025
bgavrilMS
reviewed
Aug 13, 2025
src/client/Microsoft.Identity.Client/AuthScheme/PoP/PopBindingResolver.cs
Outdated
Show resolved
Hide resolved
bgavrilMS
reviewed
Aug 13, 2025
src/client/Microsoft.Identity.Client/AuthScheme/PoP/PopBindingResolver.cs
Outdated
Show resolved
Hide resolved
bgavrilMS
reviewed
Aug 13, 2025
src/client/Microsoft.Identity.Client/Internal/Requests/ClientCredentialRequest.cs
Outdated
Show resolved
Hide resolved
bgavrilMS
reviewed
Aug 13, 2025
src/client/Microsoft.Identity.Client/AuthScheme/PoP/PopBindingResolver.cs
Outdated
Show resolved
Hide resolved
bgavrilMS
approved these changes
Aug 13, 2025
bgavrilMS
reviewed
Aug 13, 2025
src/client/Microsoft.Identity.Client/ApiConfig/AcquireTokenForClientParameterBuilder.cs
Show resolved
Hide resolved
trwalke
reviewed
Aug 14, 2025
src/client/Microsoft.Identity.Client/ApiConfig/Parameters/AcquireTokenCommonParameters.cs
Outdated
Show resolved
Hide resolved
trwalke
approved these changes
Aug 14, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor comment.
Otherwise LGTM
bgavrilMS
approved these changes
Aug 15, 2025
This was referenced Aug 16, 2025
Open
Merged
lilyydu
pushed a commit
to microsoft/teams-ai
that referenced
this pull request
Aug 20, 2025
#minor Updated [Azure.Identity](https://github.com/Azure/azure-sdk-for-net) from 1.14.2 to 1.15.0. <details> <summary>Release notes</summary> _Sourced from [Azure.Identity's releases](https://github.com/Azure/azure-sdk-for-net/releases)._ No release notes found for this version range. Commits viewable in [compare view](https://github.com/Azure/azure-sdk-for-net/commits). </details> Updated [Microsoft.Identity.Client](https://github.com/AzureAD/microsoft-authentication-library-for-dotnet) from 4.74.1 to 4.76.0. <details> <summary>Release notes</summary> _Sourced from [Microsoft.Identity.Client's releases](https://github.com/AzureAD/microsoft-authentication-library-for-dotnet/releases)._ ## 4.76.0 ## What's Changed * Removal of `ExperimentalFeatures` flag on `WithMtlsProofOfPossession` API: by @gladjohn in AzureAD/microsoft-authentication-library-for-dotnet#5402 * #5400 Fixing issue that leads to multiple active access tokens in the cache for non-tenanted oidc authority by @andkorsh in AzureAD/microsoft-authentication-library-for-dotnet#5401 * Add Service Fabric token revocation support by @gladjohn in AzureAD/microsoft-authentication-library-for-dotnet#5421 * Update NativeInterop package version to 0.19.4 by @ashok672 in AzureAD/microsoft-authentication-library-for-dotnet#5434 * Adding WithExtraBodyParameters api by @trwalke in AzureAD/microsoft-authentication-library-for-dotnet#5389 * Enable mTLS Proof‑of‑Possession for Client‑Assertion Delegates by @gladjohn in AzureAD/microsoft-authentication-library-for-dotnet#5409 ## New Contributors * @andkorsh made their first contribution in AzureAD/microsoft-authentication-library-for-dotnet#5401 **Full Changelog**: AzureAD/microsoft-authentication-library-for-dotnet@4.74.1...4.76.0 Commits viewable in [compare view](AzureAD/microsoft-authentication-library-for-dotnet@4.74.1...4.76.0). </details> Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore <dependency name> major version` will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself) - `@dependabot ignore <dependency name> minor version` will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself) - `@dependabot ignore <dependency name>` will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself) - `@dependabot unignore <dependency name>` will remove all of the ignore conditions of the specified dependency - `@dependabot unignore <dependency name> <ignore condition>` will remove the ignore condition of the specified dependency and ignore conditions </details> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5398
Changes proposed in this request
This pull request introduces significant enhancements to the mutual TLS Proof-of-Possession (mTLS PoP) functionality, refactors client assertion handling, and updates public APIs to support these changes. The most important changes include adding support for certificate-bound client assertions, refactoring the
ClientCredential
classes, and introducing new public APIs for client assertion configuration.Enhancements to mTLS Proof-of-Possession:
WithMtlsProofOfPossession
method: Updated the method to handle multiple credential types (CertificateClientCredential
andClientAssertionDelegateCredential
) and added logic for certificate-bound client assertions. Improved error handling for cases where certificates are not provided. (src/client/Microsoft.Identity.Client/ApiConfig/AcquireTokenForClientParameterBuilder.cs
, src/client/Microsoft.Identity.Client/ApiConfig/AcquireTokenForClientParameterBuilder.csL99-R126)src/client/Microsoft.Identity.Client/MsalErrorMessage.cs
, src/client/Microsoft.Identity.Client/MsalErrorMessage.csL439-R439)Refactoring of Client Assertion Handling:
ClientAssertionDelegateCredential
: Added a new class to handle client assertions supplied via a delegate, supporting JWTs with optional certificates for mTLS PoP. This replaces the removedSignedAssertionDelegateClientCredential
class. (src/client/Microsoft.Identity.Client/Internal/ClientCredential/ClientAssertionDelegateCredential.cs
, [1];src/client/Microsoft.Identity.Client/Internal/ClientCredential/SignedAssertionDelegateClientCredential.cs
, [2]src/client/Microsoft.Identity.Client/OAuth2/OAuthConstants.cs
, src/client/Microsoft.Identity.Client/OAuth2/OAuthConstants.csR69)Updates to Public APIs:
AssertionResponse
class: Introduced a new public class to encapsulate client assertions and optional certificates for token binding. (src/client/Microsoft.Identity.Client/AppConfig/AssertionResponse.cs
, src/client/Microsoft.Identity.Client/AppConfig/AssertionResponse.csR1-R22)WithClientAssertion
methods: Refactored existing methods to use the newAssertionResponse
class and added a new overload for configuring client assertions with certificate binding. (src/client/Microsoft.Identity.Client/AppConfig/ConfidentialClientApplicationBuilder.cs
, [1] [2] [3]PublicAPI.Unshipped.txt
files across multiple frameworks to include new APIs for client assertion configuration. (src/client/Microsoft.Identity.Client/PublicApi/net462/PublicAPI.Unshipped.txt
, [1];src/client/Microsoft.Identity.Client/PublicApi/net472/PublicAPI.Unshipped.txt
, [2];src/client/Microsoft.Identity.Client/PublicApi/net8.0-android/PublicAPI.Unshipped.txt
, [3]Miscellaneous Changes:
IsExternalInit
for backward compatibility: Introduced a compatibility shim forIsExternalInit
to supportinit
properties on older frameworks. (src/client/Microsoft.Identity.Client/IsExternalInit.cs
, src/client/Microsoft.Identity.Client/IsExternalInit.csR1-R11)src/client/Microsoft.Identity.Client/ApiConfig/AcquireTokenForClientParameterBuilder.cs
, src/client/Microsoft.Identity.Client/ApiConfig/AcquireTokenForClientParameterBuilder.csL1-R1)These changes collectively improve the flexibility and robustness of client assertion handling and enhance support for mTLS PoP scenarios.
Testing
unit
Performance impact
none
Documentation