Implement WinUI3 support for Desktop package #5411
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashok672
requested changes
Aug 1, 2025
...ent/Microsoft.Identity.Client.Desktop.WinUI3/Microsoft.Identity.Client.Desktop.WinUI3.csproj
Show resolved
Hide resolved
src/client/Microsoft.Identity.Client.Desktop.WinUI3/WebView2WebUi/WebView2WebUi.cs
Outdated
Show resolved
Hide resolved
ashok672
requested changes
Aug 1, 2025
src/client/Microsoft.Identity.Client.Desktop.WinUI3/WebView2WebUi/WebView2WebUi.cs
Outdated
Show resolved
Hide resolved
iulico-1
reviewed
Aug 1, 2025
src/client/Microsoft.Identity.Client/ApiConfig/AcquireTokenInteractiveParameterBuilder.cs
Show resolved
Hide resolved
iulico-1
reviewed
Aug 1, 2025
githubursul
reviewed
Aug 2, 2025
src/client/Microsoft.Identity.Client/ApiConfig/AcquireTokenInteractiveParameterBuilder.cs
Outdated
Show resolved
Hide resolved
…microsoft-authentication-library-for-dotnet into dharshanb/winui3Support
…microsoft-authentication-library-for-dotnet into dharshanb/winui3Support
|
Hi @DharshanBJ - this has been open for a while. Is it still relevant? |
Hi @bgavrilMS , yes, this PR is still relevant, i'm waiting on reviews for this PR. |
bgavrilMS
reviewed
Aug 15, 2025
...ent/Microsoft.Identity.Client.Desktop.WinUI3/Microsoft.Identity.Client.Desktop.WinUI3.csproj
Show resolved
Hide resolved
bgavrilMS
approved these changes
Aug 15, 2025
|
@gladjohn - can you pls review this? |
@bgavrilMS , yes i'll be adding the build changes and public documentation as part of my next work items. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses the business need outlined in AzureAD/microsoft-authentication-library-for-dotnet#4933. The proposed changes are based on the design detailed in the following document: AuthLibrariesApiReview#18287.
I had shared the preview packages in the issue discussion, many of them tested the packages and confirmed that it works for them - #4933 (comment)