Skip to content

Conversation

DharshanBJ
Copy link
Contributor

@DharshanBJ DharshanBJ commented Jul 29, 2025

This pull request addresses the business need outlined in AzureAD/microsoft-authentication-library-for-dotnet#4933. The proposed changes are based on the design detailed in the following document: AuthLibrariesApiReview#18287.

I had shared the preview packages in the issue discussion, many of them tested the packages and confirmed that it works for them - #4933 (comment)

@bgavrilMS bgavrilMS force-pushed the dharshanb/winui3Support branch from 74f8bfb to 7e54e7b Compare August 20, 2025 17:03
@DharshanBJ
Copy link
Contributor Author

@gladjohn - can you pls review this? @DharshanBJ - I think this is all good, but there may be some changes on the build we need to do.

@bgavrilMS , yes i'll be adding the build changes and public documentation as part of my next work items.

public doc is key here. to know when to use the desktop package, when to use broker and when to use the client itself and now this new package. A nice table with all dev options would be good.

@DharshanBJ understands the scenario better and should make the public docs changes. Appreciate the offer to help with the builds.

ack

@DharshanBJ
Copy link
Contributor Author

looks good, just a few comments. Also when the window closes, do we need to call dispose ?

thanks for the suggestion, added dispose to cleanup webview2 upon close

@DharshanBJ DharshanBJ merged commit b9e5aa8 into main Aug 26, 2025
11 checks passed
@DharshanBJ DharshanBJ deleted the dharshanb/winui3Support branch August 26, 2025 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants