ImdsV2: Acquire Entra Token Over mTLS #5431
Merged
+596
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gladjohn
reviewed
Aug 9, 2025
src/client/Microsoft.Identity.Client/ManagedIdentity/ImdsV2ManagedIdentitySource.cs
Outdated
Show resolved
Hide resolved
gladjohn
reviewed
Aug 9, 2025
src/client/Microsoft.Identity.Client/ManagedIdentity/ImdsV2ManagedIdentitySource.cs
Outdated
Show resolved
Hide resolved
bgavrilMS
reviewed
Aug 11, 2025
src/client/Microsoft.Identity.Client/ManagedIdentity/ImdsV2ManagedIdentitySource.cs
Outdated
Show resolved
Hide resolved
…quire_entra_token
…quire_entra_token
Robbie-Microsoft
changed the title
bgavrilMS
reviewed
Aug 29, 2025
src/client/Microsoft.Identity.Client/ManagedIdentity/V2/ImdsV2ManagedIdentitySource.cs
Outdated
Show resolved
Hide resolved
bgavrilMS
reviewed
Aug 29, 2025
| /// <exception cref="ArgumentNullException">Thrown when certificatePem or privateKey is null</exception> | ||
| /// <exception cref="ArgumentException">Thrown when certificatePem is not a valid PEM certificate</exception> | ||
| /// <exception cref="FormatException">Thrown when the certificate cannot be parsed</exception> | ||
| internal X509Certificate2 AttachPrivateKeyToCert(string certificatePem, RSA privateKey) |
There was a problem hiding this comment.
You could move all this X509 related code to the existing CommonCryptographyManager
bgavrilMS
reviewed
Aug 29, 2025
src/client/Microsoft.Identity.Client/ManagedIdentity/V2/ImdsV2ManagedIdentitySource.cs
Outdated
Show resolved
Hide resolved
bgavrilMS
reviewed
Aug 29, 2025
src/client/Microsoft.Identity.Client/ManagedIdentity/V2/ImdsV2ManagedIdentitySource.cs
Outdated
Show resolved
Hide resolved
bgavrilMS
reviewed
Aug 29, 2025
src/client/Microsoft.Identity.Client/ManagedIdentity/V2/ImdsV2ManagedIdentitySource.cs
Outdated
Show resolved
Hide resolved
bgavrilMS
reviewed
Aug 29, 2025
src/client/Microsoft.Identity.Client/ManagedIdentity/V2/ImdsV2ManagedIdentitySource.cs
Outdated
Show resolved
Hide resolved
…quire_entra_token
Robbie-Microsoft
merged commit ddc2117
into
rginsburg/msiv2_feature_branch
3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finishing up the remainder of the flow for ImdsV2... this PR builds the request to acquire the entra token over mTLS.