Attempt to fix flaky GetRemovesExpired_Async test #5569
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #5357
GetRemovesExpired_AsyncinThrottlingCacheTestsis flaky in our pipelines, occasionally failing due to the "k1" cache entry not being expired/removed like we expect it to. TheTestCleanup_Asynctest in that class does the same expiry checks, except it isn't flaky.My suspicion is a race condition caused by the task delay:
TestCleanup_Asyncused a 50ms delay, howeverGetRemovesExpired_Asyncused a 1ms delay which is the same as the expiry time. A lack of precision in the timing could be causing us to check the cache before the entry is actually expired.This PR aims to fix that by removing the delay logic entirely, and simply sets the cache entries to already be expired when they're created.