Migrate All lab helper methods to Key Vault/Region test migration. #5606
+13
−85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace direct msidlab.com API call with Key Vault data retrieval - Use MergeKVLabDataAsync pattern consistent with other migrated methods - Maintains same functionality while reducing external API dependencies
- Migrate GetArlingtonUserAsync to use MergeKVLabDataAsync with Key Vault secrets - Migrate GetArlingtonADFSUserAsync to use MergeKVLabDataAsync with Key Vault secrets - Replace direct msidlab.com API calls with pre-cached Key Vault data retrieval - Maintains same functionality while reducing external API dependencies - Uses consistent pattern with other migrated methods (B2C, default users) - Arlington ADFS migration verified working in tests - Arlington standard method has Key Vault data quality issue to be resolved separately
- Added GetCIAMUserAsync() method in LabUserHelper using Key Vault secrets - Updated all 4 CIAM integration tests to use new method instead of direct API calls - Verified all tests pass with Key Vault cached data - Improves reliability by removing dependency on msidlab.com API calls
RyAuld
changed the title
- Remove GetLabUserDataAsync (only used by obsolete GetAdfsUserAsync) - Remove GetAdfsUserAsync (no external callers, replaced by GetDefaultAdfsUserAsync) - Remove GetHybridSpaAccontAsync (no external callers, test now uses GetDefaultUserWithMultiTenantAppAsync) - Remove s_userCache field and System.Collections.Concurrent import (no longer needed) - Update TODO comments to remove references to deleted methods - All active functionality preserved, ~45 lines of obsolete code removed
RyAuld
changed the title
RyAuld
force-pushed
the
MigrateOtherAPIRequests
branch
from
70da243 to
07c7473
Compare
Avery-Dunn
approved these changes
Dec 16, 2025
bgavrilMS
approved these changes
Dec 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate Test Infrastructure to Key Vault and IMDS V2 Improvements
Overview
This PR consolidates several infrastructure improvements to MSAL.NET, focusing on migrating lab test infrastructure to use Azure Key Vault for credential management and enhancing IMDS V2 support for managed identity scenarios.
Key Changes
🔐 Test Infrastructure Migration to Key Vault
GetArlingtonADFSUserAsyncto retrieve credentials securely from Key VaultGetCIAMUserAsyncmethod with Key Vault integrationLabUserHelperas part of the migration to Key Vault-based credential management🚀 IMDS V2 and Managed Identity Improvements
ImdsProbeRetryPolicyfor more intelligent retry logic specific to IMDS probesHttpRetryConditionsfor better handling of IMDS-specific scenariosRetryPolicyFactoryto support new retry policies🧪 Test Configuration Updates
DesktopOsHelper.IsMacto work properly on .NET 10 + macOS 26📦 Project and Sample Updates
Benefits
Testing
Breaking Changes
None - this is purely an infrastructure improvement that maintains backward compatibility.
Related Issues/PRs
This PR focuses on infrastructure improvements and does not introduce any changes to the public MSAL.NET API surface or core authentication functionality.