Skip to content

Commit 4bcd9e8

Browse files
authored
Merge pull request #1001 from AzureAD/avdunn/extraqueryparams-deprecate
Deprecate extraQueryParameters
2 parents c75065b + 75bad75 commit 4bcd9e8

11 files changed

+63
-0
lines changed

msal4j-sdk/src/main/java/com/microsoft/aad/msal4j/AuthorizationCodeParameters.java

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -92,6 +92,10 @@ public Map<String, String> extraHttpHeaders() {
9292
return this.extraHttpHeaders;
9393
}
9494

95+
/**
96+
* @deprecated Not recommended for production scenarios. It will be removed in a future release, and the behavior may be replaced by a new API.
97+
*/
98+
@Deprecated
9599
public Map<String, String> extraQueryParameters() {
96100
return this.extraQueryParameters;
97101
}
@@ -173,7 +177,9 @@ public AuthorizationCodeParametersBuilder extraHttpHeaders(Map<String, String> e
173177

174178
/**
175179
* Adds additional query parameters to the token request
180+
* @deprecated Not recommended for production scenarios. It will be removed in a future release, and the behavior may be replaced by a new API.
176181
*/
182+
@Deprecated
177183
public AuthorizationCodeParametersBuilder extraQueryParameters(Map<String, String> extraQueryParameters) {
178184
this.extraQueryParameters = extraQueryParameters;
179185
return this;

msal4j-sdk/src/main/java/com/microsoft/aad/msal4j/AuthorizationRequestUrlParameters.java

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -234,6 +234,10 @@ public boolean instanceAware() {
234234
return this.instanceAware;
235235
}
236236

237+
/**
238+
* @deprecated Not recommended for production scenarios. It will be removed in a future release, and the behavior may be replaced by a new API.
239+
*/
240+
@Deprecated
237241
public Map<String, String> extraQueryParameters() {
238242
return this.extraQueryParameters;
239243
}
@@ -419,7 +423,9 @@ public Builder instanceAware(boolean val) {
419423
/**
420424
* Query parameters that you can add to the request,
421425
* in addition to the list of parameters already provided.
426+
* @deprecated Not recommended for production scenarios. It will be removed in a future release, and the behavior may be replaced by a new API.
422427
*/
428+
@Deprecated
423429
public Builder extraQueryParameters(Map<String, String> val) {
424430
this.extraQueryParameters = val;
425431
return self();

msal4j-sdk/src/main/java/com/microsoft/aad/msal4j/ClientCredentialParameters.java

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -71,6 +71,10 @@ public Map<String, String> extraHttpHeaders() {
7171
return this.extraHttpHeaders;
7272
}
7373

74+
/**
75+
* @deprecated Not recommended for production scenarios. It will be removed in a future release, and the behavior may be replaced by a new API.
76+
*/
77+
@Deprecated
7478
public Map<String, String> extraQueryParameters() {
7579
return this.extraQueryParameters;
7680
}
@@ -134,7 +138,9 @@ public ClientCredentialParametersBuilder extraHttpHeaders(Map<String, String> ex
134138

135139
/**
136140
* Adds additional query parameters to the token request
141+
* @deprecated Not recommended for production scenarios. It will be removed in a future release, and the behavior may be replaced by a new API.
137142
*/
143+
@Deprecated
138144
public ClientCredentialParametersBuilder extraQueryParameters(Map<String, String> extraQueryParameters) {
139145
this.extraQueryParameters = extraQueryParameters;
140146
return this;

msal4j-sdk/src/main/java/com/microsoft/aad/msal4j/DeviceCodeFlowParameters.java

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -70,6 +70,10 @@ public Map<String, String> extraHttpHeaders() {
7070
return this.extraHttpHeaders;
7171
}
7272

73+
/**
74+
* @deprecated Not recommended for production scenarios. It will be removed in a future release, and the behavior may be replaced by a new API.
75+
*/
76+
@Deprecated
7377
public Map<String, String> extraQueryParameters() {
7478
return this.extraQueryParameters;
7579
}
@@ -135,7 +139,9 @@ public DeviceCodeFlowParametersBuilder extraHttpHeaders(Map<String, String> extr
135139

136140
/**
137141
* Adds additional query parameters to the token request
142+
* @deprecated Not recommended for production scenarios. It will be removed in a future release, and the behavior may be replaced by a new API.
138143
*/
144+
@Deprecated
139145
public DeviceCodeFlowParametersBuilder extraQueryParameters(Map<String, String> extraQueryParameters) {
140146
this.extraQueryParameters = extraQueryParameters;
141147
return this;

msal4j-sdk/src/main/java/com/microsoft/aad/msal4j/IAcquireTokenParameters.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -62,6 +62,9 @@ interface IAcquireTokenParameters {
6262
* This can be useful for scenarios requiring custom parameters that aren't explicitly supported in the library.
6363
*
6464
* @return A map of additional query parameters to include with the token request, or null if no extra parameters are needed.
65+
*
66+
* @deprecated Not recommended for production scenarios. It will be removed in a future release, and the behavior may be replaced by a new API.
6567
*/
68+
@Deprecated
6669
Map<String, String> extraQueryParameters();
6770
}

msal4j-sdk/src/main/java/com/microsoft/aad/msal4j/IntegratedWindowsAuthenticationParameters.java

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -72,6 +72,10 @@ public Map<String, String> extraHttpHeaders() {
7272
return this.extraHttpHeaders;
7373
}
7474

75+
/**
76+
* @deprecated Not recommended for production scenarios. It will be removed in a future release, and the behavior may be replaced by a new API.
77+
*/
78+
@Deprecated
7579
public Map<String, String> extraQueryParameters() {
7680
return this.extraQueryParameters;
7781
}
@@ -129,7 +133,9 @@ public IntegratedWindowsAuthenticationParametersBuilder extraHttpHeaders(Map<Str
129133

130134
/**
131135
* Adds additional parameters to the token request
136+
* @deprecated Not recommended for production scenarios. It will be removed in a future release, and the behavior may be replaced by a new API.
132137
*/
138+
@Deprecated
133139
public IntegratedWindowsAuthenticationParametersBuilder extraQueryParameters(Map<String, String> extraQueryParameters) {
134140
this.extraQueryParameters = extraQueryParameters;
135141
return this;

msal4j-sdk/src/main/java/com/microsoft/aad/msal4j/InteractiveRequestParameters.java

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -113,6 +113,10 @@ public Map<String, String> extraHttpHeaders() {
113113
return this.extraHttpHeaders;
114114
}
115115

116+
/**
117+
* @deprecated Not recommended for production scenarios. It will be removed in a future release, and the behavior may be replaced by a new API.
118+
*/
119+
@Deprecated
116120
public Map<String, String> extraQueryParameters() {
117121
return this.extraQueryParameters;
118122
}
@@ -262,7 +266,9 @@ public InteractiveRequestParametersBuilder extraHttpHeaders(Map<String, String>
262266

263267
/**
264268
* Adds additional query parameters to the token request
269+
* @deprecated Not recommended for production scenarios. It will be removed in a future release, and the behavior may be replaced by a new API.
265270
*/
271+
@Deprecated
266272
public InteractiveRequestParametersBuilder extraQueryParameters(Map<String, String> extraQueryParameters) {
267273
this.extraQueryParameters = extraQueryParameters;
268274
return this;

msal4j-sdk/src/main/java/com/microsoft/aad/msal4j/OnBehalfOfParameters.java

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -76,6 +76,10 @@ public Map<String, String> extraHttpHeaders() {
7676
return this.extraHttpHeaders;
7777
}
7878

79+
/**
80+
* @deprecated Not recommended for production scenarios. It will be removed in a future release, and the behavior may be replaced by a new API.
81+
*/
82+
@Deprecated
7983
public Map<String, String> extraQueryParameters() {
8084
return this.extraQueryParameters;
8185
}
@@ -136,7 +140,9 @@ public OnBehalfOfParametersBuilder extraHttpHeaders(Map<String, String> extraHtt
136140

137141
/**
138142
* Adds additional parameters to the token request
143+
* @deprecated Not recommended for production scenarios. It will be removed in a future release, and the behavior may be replaced by a new API.
139144
*/
145+
@Deprecated
140146
public OnBehalfOfParametersBuilder extraQueryParameters(Map<String, String> extraQueryParameters) {
141147
this.extraQueryParameters = extraQueryParameters;
142148
return this;

msal4j-sdk/src/main/java/com/microsoft/aad/msal4j/RefreshTokenParameters.java

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -72,6 +72,10 @@ public Map<String, String> extraHttpHeaders() {
7272
return this.extraHttpHeaders;
7373
}
7474

75+
/**
76+
* @deprecated Not recommended for production scenarios. It will be removed in a future release, and the behavior may be replaced by a new API.
77+
*/
78+
@Deprecated
7579
public Map<String, String> extraQueryParameters() {
7680
return this.extraQueryParameters;
7781
}
@@ -133,7 +137,9 @@ public RefreshTokenParametersBuilder extraHttpHeaders(Map<String, String> extraH
133137

134138
/**
135139
* Adds additional parameters to the token request
140+
* @deprecated Not recommended for production scenarios. It will be removed in a future release, and the behavior may be replaced by a new API.
136141
*/
142+
@Deprecated
137143
public RefreshTokenParametersBuilder extraQueryParameters(Map<String, String> extraQueryParameters) {
138144
this.extraQueryParameters = extraQueryParameters;
139145
return this;

msal4j-sdk/src/main/java/com/microsoft/aad/msal4j/SilentParameters.java

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -119,6 +119,10 @@ public Map<String, String> extraHttpHeaders() {
119119
return this.extraHttpHeaders;
120120
}
121121

122+
/**
123+
* @deprecated Not recommended for production scenarios. It will be removed in a future release, and the behavior may be replaced by a new API.
124+
*/
125+
@Deprecated
122126
public Map<String, String> extraQueryParameters() {
123127
return this.extraQueryParameters;
124128
}
@@ -215,7 +219,9 @@ public SilentParametersBuilder extraHttpHeaders(Map<String, String> extraHttpHea
215219

216220
/**
217221
* Adds additional query parameters to the token request
222+
* @deprecated Not recommended for production scenarios. It will be removed in a future release, and the behavior may be replaced by a new API.
218223
*/
224+
@Deprecated
219225
public SilentParametersBuilder extraQueryParameters(Map<String, String> extraQueryParameters) {
220226
this.extraQueryParameters = extraQueryParameters;
221227
return this;

0 commit comments

Comments
 (0)