Skip to content

Conversation

@konstantin-msft
Copy link
Collaborator

@konstantin-msft konstantin-msft commented Jan 12, 2026

This pull request introduces telemetry support for loading external tokens and related events in the MSAL browser and common packages. The main focus is on instrumenting the TokenCache flow to provide detailed performance measurements for the loading of external tokens and its internal operations. Comprehensive tests have been added to ensure correct telemetry instrumentation and error handling.

Telemetry instrumentation for external token loading

  • Added new performance event types for external token loading and its sub-operations (LoadExternalTokens, LoadAccount, LoadIdToken, LoadAccessToken, LoadRefreshToken) in PerformanceEvent.ts.
  • Refactored TokenCache to accept a performanceClient and instrument the loadExternalTokens method and its internal functions using performance measurements, including error handling. [1] [2] [3] [4] [5] [6] [7]

Test coverage for telemetry

  • Expanded TokenCache.spec.ts tests to verify top-level and sub-operation telemetry events, including success and error scenarios for loadExternalTokens. [1] [2]

Package change logs

  • Updated change logs for both @azure/msal-browser and @azure/msal-common to reflect the addition of telemetry support for loading external tokens and related events. [1] [2]

Copilot AI review requested due to automatic review settings January 12, 2026 22:27
@konstantin-msft konstantin-msft requested a review from a team as a code owner January 12, 2026 22:27
@konstantin-msft konstantin-msft force-pushed the add_load_external_token_telemetry_config_v4 branch from 85ec656 to 603d8ef Compare January 12, 2026 22:32
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@konstantin-msft konstantin-msft enabled auto-merge (squash) January 12, 2026 23:40
@konstantin-msft konstantin-msft merged commit da207d2 into dev Jan 12, 2026
8 checks passed
@konstantin-msft konstantin-msft deleted the add_load_external_token_telemetry_config_v4 branch January 12, 2026 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants