Add correlationId to POST request query params#8308
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Propagates correlationId into the /authorize POST form action URL query string in msal-browser to improve end-to-end request traceability (e.g., through gateways), with accompanying unit tests to validate behavior.
Changes:
- Add
client-request-id(correlationId) to the query params used for the formactionURL ingetEARFormandgetCodeForm. - Extend protocol tests to verify correlationId appears in both the POST body inputs and the form action URL query string.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| lib/msal-browser/src/protocol/Authorize.ts | Adds correlationId to the query params Map used to build the form action URL for EAR and auth-code POST forms. |
| lib/msal-browser/test/protocol/Authorize.spec.ts | Adds assertions/tests to ensure correlationId is present in the authorize URL query params (EAR) and both query + body (code form). |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
hectormmg
commented
Feb 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds support for propagating the
correlationIdin authorization requests to ensure traceability across services. The main changes involve updating thegetEARFormandgetCodeFormfunctions to include thecorrelationIdin the query parameters, and adding tests to verify this behavior.Enhancements to correlationId propagation:
getEARFormandgetCodeForminAuthorize.tsto add thecorrelationIdto the query parameters, allowing gateways to propagate it to identity providers. [1] [2]Testing improvements:
Authorize.spec.tsto verify that thecorrelationIdis present in both the post body and query parameters of the authorization forms. [1] [2]