Skip to content

[v5] Add new authority metadata#8310

Open
hectormmg wants to merge 3 commits intomsal-v5from
sovcloud-metadata-v5
Open

[v5] Add new authority metadata#8310
hectormmg wants to merge 3 commits intomsal-v5from
sovcloud-metadata-v5

Conversation

@hectormmg
Copy link
Member

This pull request adds support for new SovCloud authority metadata in the @azure/msal-common package, enhancing authentication capabilities for France, Germany, and Singapore SovCloud environments. The changes primarily involve updating authority metadata and test constants to recognize these new hosts.

Authority metadata updates:

  • Added new SovCloud authority entries for France (login.sovcloud-identity.fr), Germany (login.sovcloud-identity.de), and Singapore (login.sovcloud-identity.sg) to the rawMetdataJSON in AuthorityMetadata.ts.

Test constants updates:

  • Added SovCloud host constants for France, Germany, and Singapore in CLOUD_HOSTS within StringConstants.ts.
  • Updated METADATA_ALIASES in StringConstants.ts to include SovCloud aliases for France, Germany, and Singapore.

Release notes:

  • Added a patch change file documenting the addition of new authority metadata for SovCloud environments.

@hectormmg hectormmg requested a review from a team as a code owner February 7, 2026 03:19
Copilot AI review requested due to automatic review settings February 7, 2026 03:19
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds hardcoded authority metadata for additional SovCloud environments in @azure/msal-common, enabling instance discovery + endpoint metadata support for France, Germany, and Singapore SovCloud authority hosts.

Changes:

  • Added new SovCloud entries to InstanceDiscoveryMetadata (preferred network/cache + aliases).
  • Updated msal-common test-kit cloud host constants and alias mappings for the new SovCloud hosts.
  • Added a Beachball patch change file for @azure/msal-common.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
lib/msal-common/src/authority/AuthorityMetadata.ts Adds France/Germany/Singapore SovCloud entries to hardcoded instance discovery metadata.
lib/msal-common/test/test_kit/StringConstants.ts Adds SovCloud hosts and metadata alias mappings used by authority metadata unit tests.
change/@azure-msal-common-b6feb9cb-1882-4142-b4ae-e3aa14d331e1.json Patch change file documenting the new authority metadata support.

Comment on lines +300 to +302
SovCloudFR: "login.sovcloud-identity.fr",
SovCloudDE: "login.sovcloud-identity.de",
SovCloudSG: "login.sovcloud-identity.sg",
Copy link

Copilot AI Feb 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New SovCloud hosts were added to CLOUD_HOSTS/METADATA_ALIASES, but TEST_CONFIG.CLOUD_DISCOVERY_METADATA (the sample instance discovery network response) still only contains the older clouds. This leaves the test-kit data inconsistent and can cause future tests that rely on CLOUD_DISCOVERY_METADATA to miss coverage for these new environments. Please update CLOUD_DISCOVERY_METADATA to include the France/Germany/Singapore SovCloud entries as well (preferred_network/preferred_cache/aliases).

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant