Conversation
change/@azure-msal-common-b6feb9cb-1882-4142-b4ae-e3aa14d331e1.json
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Pull request overview
Adds hardcoded authority metadata for additional SovCloud environments in @azure/msal-common, enabling instance discovery + endpoint metadata support for France, Germany, and Singapore SovCloud authority hosts.
Changes:
- Added new SovCloud entries to
InstanceDiscoveryMetadata(preferred network/cache + aliases). - Updated msal-common test-kit cloud host constants and alias mappings for the new SovCloud hosts.
- Added a Beachball patch change file for
@azure/msal-common.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| lib/msal-common/src/authority/AuthorityMetadata.ts | Adds France/Germany/Singapore SovCloud entries to hardcoded instance discovery metadata. |
| lib/msal-common/test/test_kit/StringConstants.ts | Adds SovCloud hosts and metadata alias mappings used by authority metadata unit tests. |
| change/@azure-msal-common-b6feb9cb-1882-4142-b4ae-e3aa14d331e1.json | Patch change file documenting the new authority metadata support. |
| SovCloudFR: "login.sovcloud-identity.fr", | ||
| SovCloudDE: "login.sovcloud-identity.de", | ||
| SovCloudSG: "login.sovcloud-identity.sg", |
There was a problem hiding this comment.
New SovCloud hosts were added to CLOUD_HOSTS/METADATA_ALIASES, but TEST_CONFIG.CLOUD_DISCOVERY_METADATA (the sample instance discovery network response) still only contains the older clouds. This leaves the test-kit data inconsistent and can cause future tests that rely on CLOUD_DISCOVERY_METADATA to miss coverage for these new environments. Please update CLOUD_DISCOVERY_METADATA to include the France/Germany/Singapore SovCloud entries as well (preferred_network/preferred_cache/aliases).
This pull request adds support for new SovCloud authority metadata in the
@azure/msal-commonpackage, enhancing authentication capabilities for France, Germany, and Singapore SovCloud environments. The changes primarily involve updating authority metadata and test constants to recognize these new hosts.Authority metadata updates:
login.sovcloud-identity.fr), Germany (login.sovcloud-identity.de), and Singapore (login.sovcloud-identity.sg) to therawMetdataJSONinAuthorityMetadata.ts.Test constants updates:
CLOUD_HOSTSwithinStringConstants.ts.METADATA_ALIASESinStringConstants.tsto include SovCloud aliases for France, Germany, and Singapore.Release notes: