Specify verify=True to hopefully satisfy CodeQL #792
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gladjohn
approved these changes
Feb 19, 2025
Avery-Dunn
reviewed
Feb 19, 2025
Avery-Dunn
approved these changes
Feb 20, 2025
|
Accidentally hit the close button. This PR is actually merged in now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a last resort to keep a test case that would still be useful in manual testing, this PR tentatively keeps the test cases in code base but skips it from test automation. This PR also hardcodes the
verifyparameter toTruein therequests.getcalls in thetest_at_pop_calling_patternmethod intests/test_e2e.py, so it can hopefully satisfy CodeQL.