Fix initialization of ConfidentialClientApplicationOptions in MergedOptions#3760
Open
cpp11nullptr wants to merge 3 commits intomasterfrom
Open
Fix initialization of ConfidentialClientApplicationOptions in MergedOptions#3760cpp11nullptr wants to merge 3 commits intomasterfrom
cpp11nullptr wants to merge 3 commits intomasterfrom
Conversation
Contributor
Author
|
Related bug is #3750 |
added 2 commits
April 1, 2026 10:18
…tions-concurrency-issue
…tions-concurrency-issue
gladjohn
approved these changes
Apr 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
ConfidentialClientApplicationOptionsproperty getter inMergedOptionsassignes a new empty instance to the backing field, then populated it - allowing a concurrent thread to observe the partially-initialized (empty) object. This caused sporadic "MsalClientException: No ClientId was specified" errors under concurrent GraphServiceClient usage.Fix
Build and populate the
ConfidentialClientApplicationOptionsinstance in a local variable, then atomically publish it usingInterlocked.CompareExchange- this ensures no thread observes an unpopulated instance.