[AutoPR Microsoft.Azure.Management.Authorization] Exposing reviewers property on accessReviewInstance model #4271
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![openapi-sdkautomation[bot]](https://avatars.githubusercontent.com/in/10463?s=60&v=4){kind=small}
openapi-sdkautomation
bot
force-pushed
the
sdkAuto/14560/Microsoft.Azure.Management.Authorization
branch
2 times, most recently
from
e429208 to
f9a7cb5
Compare
26 tasks
openapi-sdkautomation
bot
force-pushed
the
sdkAuto/14560/Microsoft.Azure.Management.Authorization
branch
5 times, most recently
from
15f4b79 to
6130669
Compare
openapi-sdkautomation
bot
force-pushed
the
sdkAuto/14560/Microsoft.Azure.Management.Authorization
branch
from
6130669 to
e8a668e
Compare
openapi-sdkautomation
bot
force-pushed
the
sdkAuto/14560/Microsoft.Azure.Management.Authorization
branch
from
e8a668e to
2af5607
Compare
Using the same build tool version for mgmt track 1 build prop
… SQL DW Gen3 API (2020-04-01-preview) (Azure#21769) * [Synapse] - Build SDK based on 2021-04-01-preview and add SQL v3 support * Update session records * Regenerate code based on the latest swagger * Minor fix Co-authored-by: Dongwei Wang <[email protected]>
Co-authored-by: Christopher Scott <[email protected]>
* Bring changes from JS docs metadata * Move business logic inside Update-DocsMsMetadata.ps1 * Update with the latest changes in JS PR * Update from latest PR feedback * Add check for empty path to prevent crashes when creating relative paths Co-authored-by: Daniel Jurek <[email protected]>
- Switch to using rest instead of cli for querying work items as cli is limited to 1000 items only. - Fix issues with Generated fields not being set. - Correctly sort older workitems by version isntead of string. Co-authored-by: Wes Haggard <[email protected]>
* Rebase * Monitor Query SDK README/samples updates
* edit pass on AuthorizationCodeCredential class description Remove the hard-coded locale and change "and" to "an". * Update sdk/identity/Azure.Identity/src/AuthorizationCodeCredential.cs Co-authored-by: Jesse Squire <[email protected]> Co-authored-by: Jesse Squire <[email protected]>
* remove table name from Uri in TableClient ctor
The focus of these changes is to tune the logging level for storage operations in order to reduce the large amount that get emitted for routine and expected operations, such as inspecting and renewing ownership for partitions. These have been moved to `verbose` to reduce noise.
openapi-sdkautomation
bot
force-pushed
the
sdkAuto/14560/Microsoft.Azure.Management.Authorization
branch
from
2af5607 to
fe14cae
Compare
* Disable release date check * Release check is not finding release date Co-authored-by: Praveen Kuttappan <[email protected]>
* Migrate DataCollectionRules from 2019-11-01-preview to 2021-04-01 * Migrate DCRA from 2019-11-01-preview to 2021-04-01 * Create DataCollectionEnpoints classes for api version 2021-04-01 (private link) * Test Session Record * Update metadata * Update AssemblyInfo.cs * Adding DCE to SdkInfo * Add support for Error Response from common-type v2 * Triggering checks * Generation from specs RP in review * Latest ResourceGroupName definition * Fixing resource group names in basic tests * Fix AlertTest * Generating package-2021-04 * Fix MetricsTests.cs * Fix MetricsTests * Delete src/SDKs/_metadata/ content
…zure#22358) # All SDK Contribution checklist: This checklist is used to make sure that common guidelines for a pull request are followed. - [ ] **Please open PR in `Draft` mode if it is:** - Work in progress or not intended to be merged. - Encountering multiple pipeline failures and working on fixes. - [ ] If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above. - [ ] **I have read the [contribution guidelines](https://github.com/Azure/azure-sdk-for-net/blob/main/CONTRIBUTING.md).** - [ ] **The pull request does not introduce [breaking changes](https://github.com/dotnet/corefx/blob/master/Documentation/coding-guidelines/breaking-change-rules.md).** ### [General Guidelines and Best Practices](https://github.com/Azure/azure-sdk-for-net/blob/main/CONTRIBUTING.md#general-guidelines) - [ ] Title of the pull request is clear and informative. - [ ] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, [see this page](https://github.com/Azure/azure-powershell/blob/master/documentation/development-docs/cleaning-up-commits.md). ### [Testing Guidelines](https://github.com/Azure/azure-sdk-for-net/blob/main/CONTRIBUTING.md#testing-guidelines) - [ ] Pull request includes test coverage for the included changes. ### [SDK Generation Guidelines](https://github.com/Azure/azure-sdk-for-net/blob/main/CONTRIBUTING.md#sdk-generation-guidelines) - [ ] The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code. (Track 2 only) - [ ] The `*.csproj` and `AssemblyInfo.cs` files have been updated with the new version of the SDK. Please double check nuget.org current release version. ## Additional management plane SDK specific contribution checklist: Note: Only applies to `Microsoft.Azure.Management.[RP]` or `Azure.ResourceManager.[RP]` - [ ] Include updated [management metadata](https://github.com/Azure/azure-sdk-for-net/tree/main/eng/mgmt/mgmtmetadata). - [ ] Update AzureRP.props to add/remove version info to maintain up to date API versions. ### Management plane SDK Troubleshooting - If this is very first SDK for a services and you are adding new service folders directly under /SDK, please add `new service` label and/or contact assigned reviewer. - If the check fails at the `Verify Code Generation` step, please ensure: - Do not modify any code in generated folders. - Do not selectively include/remove generated files in the PR. - Do use `generate.ps1/cmd` to generate this PR instead of calling `autorest` directly. Please pay attention to the @microsoft.csharp version output after running `generate.ps1`. If it is lower than current released version (2.3.82), please run it again as it should pull down the latest version. **Note: We have recently updated the PSH module called by `generate.ps1` to emit additional data. This would help reduce/eliminate the Code Verification check error. Please run following command**: `dotnet msbuild eng/mgmt.proj /t:Util /p:UtilityName=InstallPsModules` ### Old outstanding PR cleanup Please note: If PRs (including draft) has been out for more than 60 days and there are no responses from our query or followups, they will be closed to maintain a concise list for our reviewers.
# All SDK Contribution checklist: This checklist is used to make sure that common guidelines for a pull request are followed. - [ ] **Please open PR in `Draft` mode if it is:** - Work in progress or not intended to be merged. - Encountering multiple pipeline failures and working on fixes. - [ ] If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above. - [ ] **I have read the [contribution guidelines](https://github.com/Azure/azure-sdk-for-net/blob/main/CONTRIBUTING.md).** - [ ] **The pull request does not introduce [breaking changes](https://github.com/dotnet/corefx/blob/master/Documentation/coding-guidelines/breaking-change-rules.md).** ### [General Guidelines and Best Practices](https://github.com/Azure/azure-sdk-for-net/blob/main/CONTRIBUTING.md#general-guidelines) - [ ] Title of the pull request is clear and informative. - [ ] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, [see this page](https://github.com/Azure/azure-powershell/blob/master/documentation/development-docs/cleaning-up-commits.md). ### [Testing Guidelines](https://github.com/Azure/azure-sdk-for-net/blob/main/CONTRIBUTING.md#testing-guidelines) - [ ] Pull request includes test coverage for the included changes. ### [SDK Generation Guidelines](https://github.com/Azure/azure-sdk-for-net/blob/main/CONTRIBUTING.md#sdk-generation-guidelines) - [ ] The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code. (Track 2 only) - [ ] The `*.csproj` and `AssemblyInfo.cs` files have been updated with the new version of the SDK. Please double check nuget.org current release version. ## Additional management plane SDK specific contribution checklist: Note: Only applies to `Microsoft.Azure.Management.[RP]` or `Azure.ResourceManager.[RP]` - [ ] Include updated [management metadata](https://github.com/Azure/azure-sdk-for-net/tree/main/eng/mgmt/mgmtmetadata). - [ ] Update AzureRP.props to add/remove version info to maintain up to date API versions. ### Management plane SDK Troubleshooting - If this is very first SDK for a services and you are adding new service folders directly under /SDK, please add `new service` label and/or contact assigned reviewer. - If the check fails at the `Verify Code Generation` step, please ensure: - Do not modify any code in generated folders. - Do not selectively include/remove generated files in the PR. - Do use `generate.ps1/cmd` to generate this PR instead of calling `autorest` directly. Please pay attention to the @microsoft.csharp version output after running `generate.ps1`. If it is lower than current released version (2.3.82), please run it again as it should pull down the latest version. **Note: We have recently updated the PSH module called by `generate.ps1` to emit additional data. This would help reduce/eliminate the Code Verification check error. Please run following command**: `dotnet msbuild eng/mgmt.proj /t:Util /p:UtilityName=InstallPsModules` ### Old outstanding PR cleanup Please note: If PRs (including draft) has been out for more than 60 days and there are no responses from our query or followups, they will be closed to maintain a concise list for our reviewers.
…1880) * Generate SDK for 2021-01-01-preview * Update Azure Stack HCI tests * Regenerate with generate.ps1 * Mitigate breaking changes with customizations
Co-authored-by: Christopher Scott <[email protected]>
* Add support for Secure Key Release Resolves Azure#22312 * Resolve PR feedback and add tests * Resolve PR feedback
* remove the different types of resourceIdentifier * update snippets * move files to more appropriate folders
Increment package version after release of Azure.Communication.Chat
* Update to latest OpenAPI definitions Mostly case changes like Knowledgebase to KnowledgeBase * Resolve APIView feedback
* Remove unused shared code * Add hyperlinks to some search query options * Add all SearchOptions properties in Copy
* Remove duplicated content from Azure.Core Response.md * Update README * Restore AsyncPageable snippet * Restore AsyncPageableLoop snippet * Remove trailing whitespacein ResponseSamples.cs * Remove 2 unused snippets
* rename to use Get for List methods * update api / snippets * update based on comments
Co-authored-by: scbedd <[email protected]>
* Question Answering 1.0.0-beta.1 release * Update CHANGELOG and comments
Co-authored-by: daiyukun <daiyu@xps>
…Azure#21837) * update auth version * add metadata * update generate.ps1 * trigger pipelines * update version
* add EB never to classes that were missing it * update api * revert changes on core file * update api after merge
* rename base classes and flatten operation / container * fix inherit doc issue * Fix unit test failures * update api after merge from main * update api after merge
Co-authored-by: Yang Chen <[email protected]>
…es (Azure#22899) Co-authored-by: praveenkuttappan <[email protected]>
…ore.tests depend on some things in there (Azure#22940)
openapi-sdkautomation
bot
force-pushed
the
sdkAuto/14560/Microsoft.Azure.Management.Authorization
branch
from
fe14cae to
3bab3a3
Compare
* update name from tryget to getifexists * update to return Response<T> for GetIfExists and CheckIfExists * update api * update ManageGroup to adop if exists changes * update subscription to adopt if exists changes * update features to use new if exists * update generic resource to use new if exists * update provider to use new if exists * update resource group to use new if exists * final changes * update api after changes * update snippets to not use var update typo in readme * one more typo * update list references
Merge 585055674324f39b8cfabeb9bec58c5130705227 into 444d527ca9ba163e65ad4ce9fc888a6f69940a4c
openapi-sdkautomation
bot
force-pushed
the
sdkAuto/14560/Microsoft.Azure.Management.Authorization
branch
from
3bab3a3 to
a92bead
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create to sync Azure/azure-rest-api-specs#14560
Installation Instructions
In order to use the generated nuget package in your app, you will have to use it from a private feed.
To create a private feed, see the following link:
https://docs.microsoft.com/en-us/nuget/hosting-packages/local-feeds
This will allow you to create a new local feed and add the location of the new feed as one of the sources.
Direct Download
The generated package can be directly downloaded from here: