consistency between loaded data values and arrays, enforcing metadata#41
Closed
consistency between loaded data values and arrays, enforcing metadata#41
Conversation
ahoermann
reviewed
May 28, 2025
| # data, units and variance are required | ||
| value: np.ndarray = field(validator=v.instance_of(np.ndarray)) | ||
| units: pint.Unit = field(validator=v.instance_of(ureg.Unit)) | ||
| variance: pint.Unit = field(validator=v.instance_of(ureg.Unit)) |
Collaborator
There was a problem hiding this comment.
shouldn't variance be a np.ndarray as well?
Collaborator
Author
There was a problem hiding this comment.
yes, but with the changes to BaseData, sourceData should become redundant again..
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need a way to ensure loaded data (e.g. a photon flux or wavelength, but also flat field arrays) come with units and variance.
With this change, every IoSource has to ensure loaded data comes with some sort of unit and variance. This way, the processsteps can operate on BaseData elements and propagate units and uncertainties (in the form of variance propagation).