artefacts storage & add a benchmark guide #34
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
div-tyg
changed the title
joergfunger
requested changes
Oct 29, 2025
Member
joergfunger
left a comment
joergfunger
left a comment
There was a problem hiding this comment.
Thanks for the first documentation. IMO it needs some more detailed explanation of the background in general (so how everything works, what a parameter_file represents, how the workflow is configured and executed), and then a section on how to add a tool for an existing benchmark, and then howto create a new benchmark.
joergfunger
reviewed
Oct 31, 2025
benchmarks/linear-elastic-plate-with-hole/workflow_creation_guide.md
Outdated
Show resolved
Hide resolved
benchmarks/linear-elastic-plate-with-hole/workflow_creation_guide.md
Outdated
Show resolved
Hide resolved
benchmarks/linear-elastic-plate-with-hole/workflow_creation_guide.md
Outdated
Show resolved
Hide resolved
benchmarks/linear-elastic-plate-with-hole/workflow_creation_guide.md
Outdated
Show resolved
Hide resolved
benchmarks/linear-elastic-plate-with-hole/workflow_creation_guide.md
Outdated
Show resolved
Hide resolved
benchmarks/linear-elastic-plate-with-hole/workflow_creation_guide.md
Outdated
Show resolved
Hide resolved
benchmarks/linear-elastic-plate-with-hole/workflow_creation_guide.md
Outdated
Show resolved
Hide resolved
benchmarks/linear-elastic-plate-with-hole/workflow_creation_guide.md
Outdated
Show resolved
Hide resolved
benchmarks/linear-elastic-plate-with-hole/workflow_creation_guide.md
Outdated
Show resolved
Hide resolved
benchmarks/linear-elastic-plate-with-hole/workflow_creation_guide.md
Outdated
Show resolved
Hide resolved
added 7 commits
October 31, 2025 18:25
joergfunger
requested changes
Nov 5, 2025
Member
joergfunger
left a comment
joergfunger
left a comment
There was a problem hiding this comment.
A couple of remarks, and the CI pipeline is not working, the rest seems very good. Hope that we could merge that before tomorrows meeting.
benchmarks/linear-elastic-plate-with-hole/fenics/run_fenics_simulation.py
Outdated
Show resolved
Hide resolved
benchmarks/linear-elastic-plate-with-hole/kratos/create_kratos_input.py
Outdated
Show resolved
Hide resolved
joergfunger
approved these changes
Nov 7, 2025
div-tyg
deleted the
33-rectify-artefacts-storage-and-modify-folder-structure-to-include-software-tool
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.