Added bowtie2 and SNAP aligners (resolves #102)#105
Open
fnothaft wants to merge 1 commit intoBD2KGenomics:masterfrom
Open
Added bowtie2 and SNAP aligners (resolves #102)#105fnothaft wants to merge 1 commit intoBD2KGenomics:masterfrom
fnothaft wants to merge 1 commit intoBD2KGenomics:masterfrom
Conversation
jvivian
approved these changes
Aug 14, 2017
| def run_bowtie2(job, | ||
| read1, | ||
| name1, name2, name3, name4, rev1, rev2, ref, | ||
| read2=None): |
Collaborator
There was a problem hiding this comment.
Is this being called directly from the tool that generates the index files? It might be a bit cleaner to pass a dict of IDs, but if you'd prefer it this way that's fine.
Contributor
Author
There was a problem hiding this comment.
I am OK either way. Let me know if you have strong preferences.
Contributor
Author
There was a problem hiding this comment.
Actually, I've been thinking about this more (i.e., actually wiring up the tools) and you're correct. I'll be refactoring this shortly.
| '-o', '-bam', '/data/sample.bam', | ||
| '-t', str(job.cores)] | ||
| else: | ||
|
|
Collaborator
There was a problem hiding this comment.
You think whitespace is free or something?
| if not sort: | ||
| return job.fileStore.writeGlobalFile(os.path.join(work_dir, 'sample.bam')) | ||
| else: | ||
| return (job.fileStore.writeGlobalFile(os.path.join(work_dir, 'sample.bam')), |
Collaborator
There was a problem hiding this comment.
Minor: outermost parentheses unnecessary as more than one item is always returned as a tuple.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.