Skip to content

Update routes.py #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update routes.py #2

wants to merge 1 commit into from

Conversation

@BIPLAVGHOSAL
Copy link
Owner

@BIPLAVGHOSAL BIPLAVGHOSAL commented May 3, 2025

No description provided.

github-advanced-security[bot]
github-advanced-security bot found potential problems May 3, 2025
View reviewed changes
server/routes.py
if name:
cursor.execute(
"SELECT * FROM books WHERE name LIKE %s", name
"SELECT * FROM books WHERE name LIKE '%" + name + "%'"

Check failure

Code scanning / CodeQL

SQL query built from user-controlled sources High

This SQL query depends on a
user-provided value
Loading
.

Copilot Autofix

AI 7 months ago

To fix the issue, the SQL query on line 16 should be rewritten to use parameterized queries, which safely embed user input into the query. This approach prevents SQL injection by ensuring that user input is treated as data rather than executable code.

Specifically:

  1. Replace the string concatenation in the query with a parameterized query using placeholders (%s).
  2. Pass the name parameter as an argument to the execute method, ensuring it is properly escaped by the database driver.
Suggested changeset 1
server/routes.py

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/server/routes.py b/server/routes.py
--- a/server/routes.py
+++ b/server/routes.py
@@ -15,3 +15,3 @@
         cursor.execute(
-            "SELECT * FROM books WHERE name LIKE '%" + name + "%'"
+            "SELECT * FROM books WHERE name LIKE %s", ("%" + name + "%",)
         )
EOF
@@ -15,3 +15,3 @@
cursor.execute(
"SELECT * FROM books WHERE name LIKE '%" + name + "%'"
"SELECT * FROM books WHERE name LIKE %s", ("%" + name + "%",)
)
Copilot is powered by AI and may make mistakes. Always verify output.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@BIPLAVGHOSAL