Skip to content

Update dashboard for new date format in database #363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
EZoni merged 7 commits into from
Jan 20, 2026
Merged

Update dashboard for new date format in database #363

Changes from 5 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
41b9507
Update dashboard for new date format in database
RemiLehe Jan 16, 2026
cb4bf4a
Fix formatting
RemiLehe Jan 16, 2026
dc9dd90
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jan 16, 2026
f0e74df
Cleanup
RemiLehe Jan 16, 2026
ff32fad
Merge branch 'update_dates' of github.com:RemiLehe/synapse into updat…
RemiLehe Jan 16, 2026
f7cb782
Apply suggestions from code review
RemiLehe Jan 20, 2026
f41231b
Fix format string
RemiLehe Jan 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 17 additions & 4 deletions dashboard/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,11 @@ def load_data(db):
exp_data["_id"] = exp_data["_id"].astype(str)
if "_id" in sim_data.columns:
sim_data["_id"] = sim_data["_id"].astype(str)
# Convert 'date' field from datetime object to string
if "date" in exp_data.columns:
exp_data["date"] = exp_data["date"].astype(str)
if "date" in sim_data.columns:
sim_data["date"] = sim_data["date"].astype(str)
Copy link
Member

@EZoni EZoni Jan 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this could be done with less code. Would this be equivalent?

# Store '_id', 'date' as string
for key in ["_id", "date"]:
    if key in exp_data.columns:
        exp_data[key] = exp_data[key].astype(str)
    if key in sim_data.columns:
        sim_data[key] = sim_data[key].astype(str)

return (exp_data, sim_data)


Expand Down Expand Up @@ -207,10 +212,18 @@ def hover_section(title, cols, hover_data):
if not cols:
return []
section = [f"<br><b>{title}</b>"]
section += [
f"{col}=%{{customdata[{hover_data.index(col)}]:.4g}}"
for col in cols
]
for col in cols:
Copy link
Contributor Author

@RemiLehe RemiLehe Jan 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This solves a previously existing issue, where the hover box would show date=NaN, because the code attempted to format a string (e.g. 2026-01-16 12:00:00) with .4g which is for numerical values (displaying them with 4 significant digits).

# Check if column is "date"
if col == "date":
# For string/date columns, use no format specifier (displays as-is)
section.append(
f"{col}=%{{customdata[{hover_data.index(col)}]}}"
)
else:
# Use numeric formatting for numeric columns
section.append(
f"{col}=%{{customdata[{hover_data.index(col)}]:.4g}}"
)
return section

# Determine which data is shown when hovering over the plot
Expand Down