-
Notifications
You must be signed in to change notification settings - Fork 4
Add start/end date selectors for experiment filtering #370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
b1e1acf
Add start/end date selectors for experiment filtering
EZoni ca767ab
Implement date filter for experimental data
EZoni df78839
Merge branch 'main' into date_selection
EZoni 8569361
Use VDateInput component
EZoni 27b12b5
Fix date filter math
EZoni 06264f0
Improve code to compute the end date correction
EZoni 7f4aa19
Simplify dictionary unpacking
EZoni 2077a1c
Explain logic for calculation of end_date_correction
EZoni 4ef4d93
Merge branch 'main' into date_selection
EZoni c2c92e4
Use date filter in the ML training code
EZoni 4b66f8e
Merge branch 'main' into date_selection
RemiLehe 707d7b2
Merge branch 'main' into date_selection
EZoni 7fc0054
Apply suggestions from code review
RemiLehe File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,6 @@ | ||
| from pathlib import Path | ||
| from trame.app import get_server | ||
| from trame.widgets import vuetify3 as vuetify | ||
|
|
||
|
|
||
| EXPERIMENTS_PATH = Path.cwd().parent / "experiments/" | ||
|
|
@@ -8,6 +9,7 @@ | |
| server = get_server(client_type="vue3") | ||
| state = server.state | ||
| ctrl = server.controller | ||
| vuetify.enable_lab() # Enable Labs components | ||
|
|
||
|
|
||
| def initialize_state(): | ||
|
|
@@ -23,6 +25,7 @@ def initialize_state(): | |
| ][0] | ||
| print(f"Setting default experiment to {default_experiment}...") | ||
| state.experiment = default_experiment | ||
| state.experiment_date_range = [] | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If the will |
||
| # ML model | ||
| state.model_type = "Neural Network (single)" | ||
| state.model_training = False | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should add to the configuration file a new section that reads, e.g.,