Pass path to config file when running training_ml.py and update README#372
Merged
Pass path to config file when running training_ml.py and update README#372
training_ml.py and update README#372Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
RemiLehe
commented
Jan 30, 2026
training_ml.pytraining_ml.py and update README
EZoni
reviewed
Jan 30, 2026
EZoni
reviewed
Jan 30, 2026
Member
There was a problem hiding this comment.
Since the ML training README starts with titles at level # (not ##) could we maybe adjust the title levels in the dashboard README as well, to make the two consistent in formatting and style?
Member
There was a problem hiding this comment.
We can do this in a separate PR in the interest of having the full testing/debugging mode feature available asap.
EZoni
reviewed
Jan 30, 2026
EZoni
reviewed
Jan 30, 2026
EZoni
reviewed
Jan 30, 2026
EZoni
reviewed
Jan 30, 2026
EZoni
reviewed
Jan 30, 2026
EZoni
reviewed
Jan 30, 2026
EZoni
reviewed
Jan 30, 2026
EZoni
reviewed
Jan 30, 2026
EZoni
reviewed
Jan 30, 2026
EZoni
reviewed
Jan 30, 2026
EZoni
reviewed
Jan 30, 2026
EZoni
reviewed
Jan 30, 2026
EZoni
reviewed
Jan 30, 2026
EZoni
reviewed
Jan 30, 2026
EZoni
reviewed
Jan 30, 2026
EZoni
reviewed
Jan 30, 2026
Co-authored-by: Edoardo Zoni <59625522+EZoni@users.noreply.github.com>
EZoni
approved these changes
Jan 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
training_ml.pyhad some complicated logic to decide where to look for the config file:https://github.com/BLAST-AI-ML/synapse/blob/main/ml/train_model.py#L70
This makes the code behavior difficult to understand/predict.
However, in practice there is only two cases that we care about:
train_model.pyrun through thesbatchfiletraining_pm.sbatch(this includes triggering the training through the dashboard, which does launchtraining_pm.sbatchvia the SFAPI): in this casetrain_model.pyuses the config file which is mounted into the container (/app/ml/config.yaml).train_model.pyrun locally from a terminal (python train_model.py ...), for training purposes: in this case, it is convenient to be able to directly point to the config file that we want to use for testing.This PR accomplishes this by replacing the
--experimentcommand line argument by--config_file_path