Skip to content

Comments

Pass path to config file when running training_ml.py and update README#372

Merged
EZoni merged 17 commits intomainfrom
path_to_config
Jan 31, 2026
Merged

Pass path to config file when running training_ml.py and update README#372
EZoni merged 17 commits intomainfrom
path_to_config

Conversation

@RemiLehe
Copy link
Contributor

The training_ml.py had some complicated logic to decide where to look for the config file:
https://github.com/BLAST-AI-ML/synapse/blob/main/ml/train_model.py#L70
This makes the code behavior difficult to understand/predict.

However, in practice there is only two cases that we care about:

  • train_model.py run through the sbatch file training_pm.sbatch (this includes triggering the training through the dashboard, which does launch training_pm.sbatch via the SFAPI): in this case train_model.py uses the config file which is mounted into the container (/app/ml/config.yaml).

  • train_model.py run locally from a terminal (python train_model.py ...), for training purposes: in this case, it is convenient to be able to directly point to the config file that we want to use for testing.

This PR accomplishes this by replacing the --experiment command line argument by --config_file_path

@RemiLehe RemiLehe changed the title [WIP] Pass path to config file when running training_ml.py Pass path to config file when running training_ml.py and update README Jan 30, 2026
@RemiLehe RemiLehe requested a review from EZoni January 30, 2026 22:17
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the ML training README starts with titles at level # (not ##) could we maybe adjust the title levels in the dashboard README as well, to make the two consistent in formatting and style?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can do this in a separate PR in the interest of having the full testing/debugging mode feature available asap.

@EZoni EZoni added ml Changes related to the ML models breaking Breaking changes labels Jan 31, 2026
@EZoni EZoni merged commit dec4386 into main Jan 31, 2026
3 checks passed
@EZoni EZoni deleted the path_to_config branch January 31, 2026 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking Breaking changes ml Changes related to the ML models

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants