[WIP] Generalized Mad-X Parser#268
Draft
np-eazy wants to merge 15 commits intoBLAST-ImpactX:developmentfrom
Draft
[WIP] Generalized Mad-X Parser#268np-eazy wants to merge 15 commits intoBLAST-ImpactX:developmentfrom
np-eazy wants to merge 15 commits intoBLAST-ImpactX:developmentfrom
Conversation
ax3l
added
changes input scripts / defaults
…to madx-parser
- mad_var - mad_cmd - mad_elem - mad_macro
- mad_main - mad_gvar - mad_core: mad_init_c
…infrastructure: - mad_core: madx_input
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
# Conflicts: # src/madx/utils/mad_str.py
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is enhancing the MAD-X lattice parser capabilities from #214 with a more general parser.
Close #104
Step 1 (WIP): Transcribe and adapt the original MadX C interpreter in Python for ImpactX. We cannot copy-paste the C files directly into ImpactX which uses C++, and we also cannot run MadX as a dependency since the latter relies on so many other dependencies. Thus, this brute-force approach is best, also given that we want to avoid tinkering with the parsing logic itself.
Step 2: Post-execution, map interpreter objects to already-defined ImpactX input file objects.