Add ActiveMQ connection in continuous mode and fix monitor_url/env handling in fastmon client #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add ActiveMQ connection in continuous mode - swf-fastmon-client: - Change the default value of monitor_url to None so that environmental variable SWF_MONITOR_URL is properly used - Define missing self.logger
michmx
reviewed
Nov 24, 2025
Member
michmx
left a comment
michmx
left a comment
There was a problem hiding this comment.
Works as it is, just adding a few comments in the implementation.
src/swf_fastmon_client/main.py
Outdated
| @app.command() | ||
| def start( | ||
| monitor_url: str = typer.Option("http://localhost:8002", "--monitor-url", "-m", help="Monitor base URL"), | ||
| monitor_url: Optional[str] = typer.Option(None, "--monitor-url", "-m", help="Monitor base URL"), |
Member
There was a problem hiding this comment.
Thanks for the fix! It would be good to add to the help message "Overwrites SWF_MONITOR_URL".
|
|
||
|
|
||
| # Connect to ActiveMQ | ||
| self.conn.connect( |
Member
There was a problem hiding this comment.
Ah, now I get it! This part is implemented in the run() of the base agent, that is why it is missing here. Thanks for the catch!
It would be cleaner to abstract the connection with the message queue in a method of the base agent, and use it in both run() and here. We can discuss it with @wenaus.
Member
There was a problem hiding this comment.
Will address it in a upcoming PR, following the discussion with @buddhasystem
michmx
reviewed
Nov 25, 2025
michmx
reviewed
Nov 25, 2025
Member
|
Adding a few |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds ActiveMQ connection logic for continuous mode in swf-fastmon-agent,
and fixes two issues in swf-fastmon-client.
Details
monitor_urlso that the environment variable is properly used.self.loggerdefinition to suppress attribute errors.